WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
170885
[JSC] Use WTF::RunLoop::Timer in CF port in JSRunLoopTimer
https://bugs.webkit.org/show_bug.cgi?id=170885
Summary
[JSC] Use WTF::RunLoop::Timer in CF port in JSRunLoopTimer
Yusuke Suzuki
Reported
2017-04-16 04:53:06 PDT
It involves using WebThread's RunLoop.
Attachments
Patch
(14.77 KB, patch)
2017-04-16 05:40 PDT
,
Yusuke Suzuki
no flags
Details
Formatted Diff
Diff
Patch
(17.28 KB, patch)
2017-04-16 05:58 PDT
,
Yusuke Suzuki
no flags
Details
Formatted Diff
Diff
Patch
(17.28 KB, patch)
2017-04-16 07:20 PDT
,
Yusuke Suzuki
no flags
Details
Formatted Diff
Diff
Patch
(17.27 KB, patch)
2017-04-16 07:46 PDT
,
Yusuke Suzuki
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2
(907.92 KB, application/zip)
2017-04-16 09:47 PDT
,
Build Bot
no flags
Details
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1
2017-04-16 05:40:38 PDT
Created
attachment 307225
[details]
Patch WIP: just make it buildable
Yusuke Suzuki
Comment 2
2017-04-16 05:58:17 PDT
Created
attachment 307226
[details]
Patch WIP: just make it buildable.
Yusuke Suzuki
Comment 3
2017-04-16 06:01:17 PDT
Comment on
attachment 307226
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=307226&action=review
> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:66 > +void JSRunLoopTimer::setRunLoop(RunLoop* runLoop)
Most important thing to do is that we need to make RunLoop::Timer destruction safe even if it is done from the different thread. This patch still lacks it.
Yusuke Suzuki
Comment 4
2017-04-16 07:20:35 PDT
Created
attachment 307228
[details]
Patch WIP: just make it buildable.
Yusuke Suzuki
Comment 5
2017-04-16 07:46:08 PDT
Created
attachment 307229
[details]
Patch WIP: just make it buildable.
Build Bot
Comment 6
2017-04-16 09:47:05 PDT
Comment on
attachment 307229
[details]
Patch
Attachment 307229
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
http://webkit-queues.webkit.org/results/3546132
New failing tests: webrtc/multi-video.html
Build Bot
Comment 7
2017-04-16 09:47:06 PDT
Created
attachment 307231
[details]
Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug