Bug 170866 - Include resource size in some existing logging
Summary: Include resource size in some existing logging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-14 17:10 PDT by Keith Rollin
Modified: 2017-04-15 19:40 PDT (History)
2 users (show)

See Also:


Attachments
Patch (6.36 KB, patch)
2017-04-14 17:39 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2017-04-14 17:10:16 PDT
In order to correlate resource load times with resource size, we log when the resource is starting to be downloaded and when the resource is finished loading. In NetworkResourceLoader::didReceiveResponse, we also log the expected resource size. However, we can only log the length if it is provided in Content-Length, which is not always the case. If it's not provided, we end up logging "length = -1". To make up for this, change NetworkResourceLoader::didFinishLoading and WebResourceLoader:: didFinishLoading to log the length once we know it.
Comment 1 Keith Rollin 2017-04-14 17:39:11 PDT
Created attachment 307170 [details]
Patch
Comment 2 WebKit Commit Bot 2017-04-15 19:40:13 PDT
Comment on attachment 307170 [details]
Patch

Clearing flags on attachment: 307170

Committed r215397: <http://trac.webkit.org/changeset/215397>
Comment 3 WebKit Commit Bot 2017-04-15 19:40:15 PDT
All reviewed patches have been landed.  Closing bug.