WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
170865
ParseInt intrinsic in DFG backend doesn't properly flush its operands
https://bugs.webkit.org/show_bug.cgi?id=170865
Summary
ParseInt intrinsic in DFG backend doesn't properly flush its operands
Saam Barati
Reported
2017-04-14 16:21:35 PDT
...
Attachments
patch
(5.80 KB, patch)
2017-04-14 16:27 PDT
,
Saam Barati
no flags
Details
Formatted Diff
Diff
patch
(4.39 KB, patch)
2017-04-14 16:29 PDT
,
Saam Barati
mark.lam
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Saam Barati
Comment 1
2017-04-14 16:27:20 PDT
Created
attachment 307166
[details]
patch
Saam Barati
Comment 2
2017-04-14 16:29:07 PDT
Comment on
attachment 307166
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=307166&action=review
> Source/JavaScriptCore/dfg/DFGOperations.h:176 > +EncodedJSValue JIT_OPERATION operationParseIntNoRadixGeneric(ExecState*, EncodedJSValue) WTF_INTERNAL; > +EncodedJSValue JIT_OPERATION operationParseIntStringNoRadix(ExecState*, JSString*) WTF_INTERNAL; > +EncodedJSValue JIT_OPERATION operationParseIntString(ExecState*, JSString*, int32_t) WTF_INTERNAL; > +EncodedJSValue JIT_OPERATION operationParseIntGeneric(ExecState*, EncodedJSValue, int32_t) WTF_INTERNAL;
I'll revert this.
Saam Barati
Comment 3
2017-04-14 16:29:53 PDT
Created
attachment 307167
[details]
patch
Mark Lam
Comment 4
2017-04-14 16:33:46 PDT
Comment on
attachment 307167
[details]
patch r=me
Geoffrey Garen
Comment 5
2017-04-14 16:39:45 PDT
r=me Big twist in the C++ auto soap opera as Saam uses auto voluntarily!
Saam Barati
Comment 6
2017-04-14 17:25:30 PDT
(In reply to Geoffrey Garen from
comment #5
)
> r=me > > Big twist in the C++ auto soap opera as Saam uses auto voluntarily!
I was actually thinking of reverting it!
Saam Barati
Comment 7
2017-04-14 19:13:35 PDT
landed in:
https://trac.webkit.org/changeset/215387/webkit
David Kilzer (:ddkilzer)
Comment 8
2017-04-21 11:43:41 PDT
<
rdar://problem/31223764
>
Michael Catanzaro
Comment 9
2017-07-01 12:15:39 PDT
***
Bug 173539
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug