Bug 170865 - ParseInt intrinsic in DFG backend doesn't properly flush its operands
Summary: ParseInt intrinsic in DFG backend doesn't properly flush its operands
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
: 173539 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-04-14 16:21 PDT by Saam Barati
Modified: 2017-07-01 12:15 PDT (History)
12 users (show)

See Also:

Attachments
patch (5.80 KB, patch)
2017-04-14 16:27 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (4.39 KB, patch)
2017-04-14 16:29 PDT, Saam Barati 		mark.lam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2017-04-14 16:21:35 PDT 
...
Comment 1 Saam Barati 2017-04-14 16:27:20 PDT 
Created attachment 307166 [details]
patch
Comment 2 Saam Barati 2017-04-14 16:29:07 PDT 
Comment on attachment 307166 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307166&action=review

> Source/JavaScriptCore/dfg/DFGOperations.h:176
> +EncodedJSValue JIT_OPERATION operationParseIntNoRadixGeneric(ExecState*, EncodedJSValue) WTF_INTERNAL;
> +EncodedJSValue JIT_OPERATION operationParseIntStringNoRadix(ExecState*, JSString*) WTF_INTERNAL;
> +EncodedJSValue JIT_OPERATION operationParseIntString(ExecState*, JSString*, int32_t) WTF_INTERNAL;
> +EncodedJSValue JIT_OPERATION operationParseIntGeneric(ExecState*, EncodedJSValue, int32_t) WTF_INTERNAL;

I'll revert this.
Comment 3 Saam Barati 2017-04-14 16:29:53 PDT 
Created attachment 307167 [details]
patch
Comment 4 Mark Lam 2017-04-14 16:33:46 PDT 
Comment on attachment 307167 [details]
patch

r=me
Comment 5 Geoffrey Garen 2017-04-14 16:39:45 PDT 
r=me

Big twist in the C++ auto soap opera as Saam uses auto voluntarily!
Comment 6 Saam Barati 2017-04-14 17:25:30 PDT 
(In reply to Geoffrey Garen from comment #5)
> r=me
> 
> Big twist in the C++ auto soap opera as Saam uses auto voluntarily!

I was actually thinking of reverting it!
Comment 7 Saam Barati 2017-04-14 19:13:35 PDT 
landed in:
https://trac.webkit.org/changeset/215387/webkit
Comment 8 David Kilzer (:ddkilzer) 2017-04-21 11:43:41 PDT 
<rdar://problem/31223764>
Comment 9 Michael Catanzaro 2017-07-01 12:15:39 PDT 
*** Bug 173539 has been marked as a duplicate of this bug. ***