Bug 170864 – [CG] To decode an image frame asynchronously, pass the native size of the image to CGImageSourceCreateThumbnailAtIndex() if it's smaller than the sizeForDrawing

• Status: RESOLVED
• Resolution: FIXED
• Component: Images

[Said Abou-Hallawa]

If we don't pass the native size explicitly to CGImageSourceCreateThumbnailAtIndex through the option kCGImageSourceThumbnailMaxPixelSize, CG creates a scaled down thumbnail image for very large images.

[Said Abou-Hallawa]

<rdar://problem/31636234>

[Said Abou-Hallawa]

Created attachment 307176 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 307176 [details]
Patch

Is this testable?

[Said Abou-Hallawa]

Created attachment 307294 [details]
Patch

[Said Abou-Hallawa]

Created attachment 307298 [details]
Patch

[Build Bot]

Comment on attachment 307298 [details]
Patch

Attachment 307298 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3553346

New failing tests:
fast/images/sprite-sheet-image-draw.html
fast/images/async-image-background-image-repeated.html

[Build Bot]

Created attachment 307311 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 307298 [details]
Patch

Attachment 307298 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3553335

New failing tests:
fast/images/async-image-background-image-repeated.html

[Build Bot]

Created attachment 307312 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 307298 [details]
Patch

Attachment 307298 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3553331

New failing tests:
fast/images/async-image-background-image-repeated.html

[Build Bot]

Created attachment 307314 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 307298 [details]
Patch

Attachment 307298 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3553426

New failing tests:
fast/images/sprite-sheet-image-draw.html
fast/images/async-image-background-image-repeated.html

[Build Bot]

Created attachment 307317 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Said Abou-Hallawa]

Created attachment 307329 [details]
Patch

[Build Bot]

Comment on attachment 307329 [details]
Patch

Attachment 307329 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3554326

New failing tests:
fast/images/sprite-sheet-image-draw.html
fast/images/async-image-background-image.html
fast/images/async-image-background-image-repeated.html

[Build Bot]

Created attachment 307335 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 307329 [details]
Patch

Attachment 307329 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3554334

New failing tests:
fast/images/sprite-sheet-image-draw.html
fast/images/async-image-background-image.html
fast/images/async-image-background-image-repeated.html

[Build Bot]

Created attachment 307336 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Said Abou-Hallawa]

Created attachment 309350 [details]
Patch

[Build Bot]

Comment on attachment 309350 [details]
Patch

Attachment 309350 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3697910

New failing tests:
fast/images/sprite-sheet-image-draw.html
fast/images/async-image-background-image-repeated.html

[Build Bot]

Created attachment 309351 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Said Abou-Hallawa]

Created attachment 309381 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 309381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309381&action=review

> Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:89
> +    unsigned maxPixelSize = DecodingOptions::maxDimension(sizeForDrawing);

maxPixelSize sounds like area, but it's now just one dimension? Could use a better name.

> Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:411
> +        // CGImageSourceCreateThumbnailAtIndex() returns a CGImage with the image native size
> +        // regardless of the subsamplingLevel. So we need to get the image native size for
> +        // SubsamplingLevel::Default and then compare it with sizeForDrawing.

I'm not sure I understand this comment.

[Said Abou-Hallawa]

Created attachment 309400 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 309400 [details]
Patch

Clearing flags on attachment: 309400

Committed r216450: <http://trac.webkit.org/changeset/216450>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.