Move common curl into a CMake file and use find_package to find CURL and OpenSSL.
Created attachment 307163 [details] Patch with CMake changes
Attachment 307163 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 307163 [details] Patch with CMake changes View in context: https://bugs.webkit.org/attachment.cgi?id=307163&action=review cool > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). This can be removed. > Source/WebCore/platform/Curl.cmake:21 > +if (CURL_FOUND) If it's required, what does this check accomplish?
(In reply to Alex Christensen from comment #3) > Comment on attachment 307163 [details] > Patch with CMake changes > > View in context: > https://bugs.webkit.org/attachment.cgi?id=307163&action=review > > cool > > > Source/WebCore/ChangeLog:8 > > + No new tests (OOPS!). > > This can be removed. Doh! > > > Source/WebCore/platform/Curl.cmake:21 > > +if (CURL_FOUND) > > If it's required, what does this check accomplish? This was more consistency with what was present in ImageDecoders.cmake. I don't personally think that its needed in that case either but annulen felt otherwise.
Created attachment 314650 [details] Patch
Comment on attachment 314650 [details] Patch Clearing flags on attachment: 314650 Committed r219156: <http://trac.webkit.org/changeset/219156>
All reviewed patches have been landed. Closing bug.