The following files all reference http://svn.webkit.org I'd like to update them to https, if there are no objections. EWSTools/build-repo.sh EWSTools/configure-git-svn.sh EWSTools/configure-svn-auth.sh EWSTools/configure-svn-config.sh EWSTools/setup-commit-queue.sh Scripts/webkitpy/common/checkout/changelog.py Scripts/webkitpy/common/checkout/scm/scm_unittest.py Scripts/webkitpy/common/config/urls.py Scripts/webkitpy/tool/commands/suggestnominations.py Scripts/webkitpy/tool/commands/suggestnominations_unittest.py
Created attachment 307149 [details] v1patch for updating Tools folder
Attachment 307149 [details] did not pass style-queue: ERROR: Tools/EWSTools/build-repo.sh:53: Line contains tab character. [whitespace/tab] [5] ERROR: Tools/EWSTools/setup-commit-queue.sh:51: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 307150 [details] v2 patch, removing previous tab.
Comment on attachment 307150 [details] v2 patch, removing previous tab. View in context: https://bugs.webkit.org/attachment.cgi?id=307150&action=review > Tools/Scripts/webkitpy/tool/commands/suggestnominations.py:55 > - _revision_regexp = re.compile(r'^git-svn-id: http://svn.webkit.org/repository/webkit/trunk@(?P<svnid>\d+) (?P<gitid>[0-9a-f\-]{36})$', re.MULTILINE) > + _revision_regexp = re.compile(r'^git-svn-id: https://svn.webkit.org/repository/webkit/trunk@(?P<svnid>\d+) (?P<gitid>[0-9a-f\-]{36})$', re.MULTILINE) Would it make sense to support both http and https here?
We are currently having problems with using https remotes in git. We will need to investigate/fix this before landing this patch.