Bug 170857 - webkitpy: Remove unneeded crash log retrieval, refactor Darwin crash retrieval
Summary: webkitpy: Remove unneeded crash log retrieval, refactor Darwin crash retrieval
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-14 14:03 PDT by Jonathan Bedard
Modified: 2017-05-09 16:19 PDT (History)
7 users (show)

See Also:


Attachments
Patch (11.10 KB, patch)
2017-04-14 14:19 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch for landing (11.20 KB, patch)
2017-05-09 15:38 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2017-04-14 14:03:30 PDT
Currently, the code which grabs crash logs assumes the iOS Simulator is being driven by another process.  This is no longer true, and iOS Simulator and Mac can use the same technique for searching for crash logs.  Devices will need a different technique.
Comment 1 Radar WebKit Bug Importer 2017-04-14 14:17:27 PDT
<rdar://problem/31635373>
Comment 2 Jonathan Bedard 2017-04-14 14:19:36 PDT
Created attachment 307145 [details]
Patch
Comment 3 Aakash Jain 2017-05-09 15:29:01 PDT
Comment on attachment 307145 [details]
Patch

looks good to me.
Comment 4 WebKit Commit Bot 2017-05-09 15:31:07 PDT
Comment on attachment 307145 [details]
Patch

Rejecting attachment 307145 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 307145, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
1 FAILED at 50.
1 out of 1 hunk FAILED -- saving rejects to file Tools/Scripts/webkitpy/port/ios_device.py.rej
patching file Tools/Scripts/webkitpy/port/ios_simulator.py
patching file Tools/Scripts/webkitpy/port/ios_simulator_unittest.py
patching file Tools/Scripts/webkitpy/port/mac.py
patching file Tools/Scripts/webkitpy/port/mac_unittest.py

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Aakash Jain']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3707973
Comment 5 Jonathan Bedard 2017-05-09 15:38:55 PDT
Created attachment 309552 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2017-05-09 16:19:11 PDT
Comment on attachment 309552 [details]
Patch for landing

Clearing flags on attachment: 309552

Committed r216556: <http://trac.webkit.org/changeset/216556>
Comment 7 WebKit Commit Bot 2017-05-09 16:19:12 PDT
All reviewed patches have been landed.  Closing bug.