Bug 170855 - Provide a way for clients to unmute a media stream.
Summary: Provide a way for clients to unmute a media stream.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-14 11:26 PDT by Andrew Gold
Modified: 2017-04-17 11:26 PDT (History)
10 users (show)

See Also:


Attachments
Proposed patch. (2.54 KB, patch)
2017-04-17 09:17 PDT, Eric Carlson
jonlee: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (896.04 KB, application/zip)
2017-04-17 10:35 PDT, Build Bot
no flags Details
Patch for landing. (2.53 KB, patch)
2017-04-17 10:43 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Gold 2017-04-14 11:26:57 PDT
Currently, WKWebView clients can mute a media stream. Provide a way for them to unmute it as well.
Comment 1 Radar WebKit Bug Importer 2017-04-17 07:57:35 PDT
<rdar://problem/31656855>
Comment 2 Eric Carlson 2017-04-17 09:17:17 PDT
Created attachment 307271 [details]
Proposed patch.
Comment 3 Build Bot 2017-04-17 09:18:22 PDT
Attachment 307271 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:50:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Jon Lee 2017-04-17 09:23:45 PDT
Comment on attachment 307271 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=307271&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:286
> +- (void)_setPageMuted:(_WKMediaMutedState)mutedState  WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));

extra space.
Comment 5 Build Bot 2017-04-17 10:35:03 PDT
Comment on attachment 307271 [details]
Proposed patch.

Attachment 307271 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3551948

New failing tests:
webrtc/multi-video.html
Comment 6 Build Bot 2017-04-17 10:35:04 PDT
Created attachment 307276 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 7 Eric Carlson 2017-04-17 10:43:16 PDT
Created attachment 307279 [details]
Patch for landing.
Comment 8 WebKit Commit Bot 2017-04-17 11:26:20 PDT
Comment on attachment 307279 [details]
Patch for landing.

Clearing flags on attachment: 307279

Committed r215420: <http://trac.webkit.org/changeset/215420>
Comment 9 WebKit Commit Bot 2017-04-17 11:26:22 PDT
All reviewed patches have been landed.  Closing bug.