Bug 170855 – Provide a way for clients to unmute a media stream.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Andrew Gold]

Currently, WKWebView clients can mute a media stream. Provide a way for them to unmute it as well.

[Radar WebKit Bug Importer]

<rdar://problem/31656855>

[Eric Carlson]

Created attachment 307271 [details]
Proposed patch.

[Build Bot]

Attachment 307271 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:50:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jon Lee]

Comment on attachment 307271 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=307271&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:286
> +- (void)_setPageMuted:(_WKMediaMutedState)mutedState  WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));

extra space.

[Build Bot]

Comment on attachment 307271 [details]
Proposed patch.

Attachment 307271 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3551948

New failing tests:
webrtc/multi-video.html

[Build Bot]

Created attachment 307276 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Eric Carlson]

Created attachment 307279 [details]
Patch for landing.

[WebKit Commit Bot]

Comment on attachment 307279 [details]
Patch for landing.

Clearing flags on attachment: 307279

Committed r215420: <http://trac.webkit.org/changeset/215420>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.