Bug 170843 - [WebIDL] Switch IDLAttributes.txt over to a more structured format so that more information can be added for each attribute
Summary: [WebIDL] Switch IDLAttributes.txt over to a more structured format so that mo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-13 20:39 PDT by Sam Weinig
Modified: 2017-04-16 17:50 PDT (History)
3 users (show)

See Also:

Attachments
Patch (88.78 KB, patch)
2017-04-13 21:24 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (95.58 KB, patch)
2017-04-14 15:32 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (97.31 KB, patch)
2017-04-14 18:07 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (97.60 KB, patch)
2017-04-15 16:52 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (97.46 KB, patch)
2017-04-15 17:29 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2017-04-13 20:39:46 PDT 
[WebIDL] Switch IDLAttributes.txt over to a more structured format so that more information can be added for each attribute
Comment 1 Sam Weinig 2017-04-13 21:24:02 PDT 
Created attachment 307090 [details]
Patch
Comment 2 Sam Weinig 2017-04-14 15:32:00 PDT 
Created attachment 307156 [details]
Patch
Comment 3 Sam Weinig 2017-04-14 18:07:50 PDT 
Created attachment 307177 [details]
Patch
Comment 4 Alex Christensen 2017-04-14 23:41:08 PDT 
Comment on attachment 307177 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307177&action=review

ews failures look related.

> Source/WebCore/animation/KeyframeEffect.idl:33
> -    Constructor([Default=Undefined] Element? target)
> +    Constructor(Element? target)

This change is not documented in the ChangeLog.

> Source/WebCore/animation/WebAnimation.idl:34
> -    Constructor([Default=Undefined] AnimationEffect? effect, [Default=Undefined] AnimationTimeline? timeline)
> +    Constructor(AnimationEffect? effect, AnimationTimeline? timeline)

Ditto.
Comment 5 Sam Weinig 2017-04-15 16:52:42 PDT 
Created attachment 307206 [details]
Patch
Comment 6 Sam Weinig 2017-04-15 17:29:29 PDT 
Created attachment 307208 [details]
Patch
Comment 7 Sam Weinig 2017-04-15 21:41:33 PDT 
(In reply to Sam Weinig from comment #6)
> Created attachment 307208 [details]
> Patch

Note, the Windows build issue exists on the bots, and is not specific to this patch.
Comment 8 Chris Dumez 2017-04-16 17:22:31 PDT 
Comment on attachment 307208 [details]
Patch

r=me
Comment 9 WebKit Commit Bot 2017-04-16 17:50:19 PDT 
Comment on attachment 307208 [details]
Patch

Clearing flags on attachment: 307208

Committed r215403: <http://trac.webkit.org/changeset/215403>
Comment 10 WebKit Commit Bot 2017-04-16 17:50:21 PDT 
All reviewed patches have been landed.  Closing bug.