RESOLVED FIXED Bug 170843
[WebIDL] Switch IDLAttributes.txt over to a more structured format so that more information can be added for each attribute 
https://bugs.webkit.org/show_bug.cgi?id=170843
Summary [WebIDL] Switch IDLAttributes.txt over to a more structured format so that mo...
Sam Weinig
Reported 2017-04-13 20:39:46 PDT
[WebIDL] Switch IDLAttributes.txt over to a more structured format so that more information can be added for each attribute
Attachments
Patch (88.78 KB, patch)
2017-04-13 21:24 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (95.58 KB, patch)
2017-04-14 15:32 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (97.31 KB, patch)
2017-04-14 18:07 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (97.60 KB, patch)
2017-04-15 16:52 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (97.46 KB, patch)
2017-04-15 17:29 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-04-13 21:24:02 PDT
Created attachment 307090 [details] Patch
Sam Weinig
Comment 2 2017-04-14 15:32:00 PDT
Created attachment 307156 [details] Patch
Sam Weinig
Comment 3 2017-04-14 18:07:50 PDT
Created attachment 307177 [details] Patch
Alex Christensen
Comment 4 2017-04-14 23:41:08 PDT
Comment on attachment 307177 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307177&action=review ews failures look related. > Source/WebCore/animation/KeyframeEffect.idl:33 > - Constructor([Default=Undefined] Element? target) > + Constructor(Element? target) This change is not documented in the ChangeLog. > Source/WebCore/animation/WebAnimation.idl:34 > - Constructor([Default=Undefined] AnimationEffect? effect, [Default=Undefined] AnimationTimeline? timeline) > + Constructor(AnimationEffect? effect, AnimationTimeline? timeline) Ditto.
Sam Weinig
Comment 5 2017-04-15 16:52:42 PDT
Created attachment 307206 [details] Patch
Sam Weinig
Comment 6 2017-04-15 17:29:29 PDT
Created attachment 307208 [details] Patch
Sam Weinig
Comment 7 2017-04-15 21:41:33 PDT
(In reply to Sam Weinig from comment #6) > Created attachment 307208 [details] > Patch Note, the Windows build issue exists on the bots, and is not specific to this patch.
Chris Dumez
Comment 8 2017-04-16 17:22:31 PDT
Comment on attachment 307208 [details] Patch r=me
WebKit Commit Bot
Comment 9 2017-04-16 17:50:19 PDT
Comment on attachment 307208 [details] Patch Clearing flags on attachment: 307208 Committed r215403: <http://trac.webkit.org/changeset/215403>
WebKit Commit Bot
Comment 10 2017-04-16 17:50:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.