Bug 170815 - Fix CMake build
Summary: Fix CMake build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-13 11:33 PDT by Alex Christensen
Modified: 2017-04-13 11:54 PDT (History)
1 user (show)

See Also:


Attachments
Patch (3.82 KB, patch)
2017-04-13 11:34 PDT, Alex Christensen
bdakin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-04-13 11:33:04 PDT
Fix CMake build
Comment 1 Alex Christensen 2017-04-13 11:34:04 PDT
Created attachment 307001 [details]
Patch
Comment 2 Beth Dakin 2017-04-13 11:35:43 PDT
Comment on attachment 307001 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307001&action=review

I'm guessing this is fixing multiple build fixes?

> Source/WebCore/PlatformMac.cmake:-266
> -    loader/cf/SubresourceLoaderCF.cpp

Is this also needed?

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:-761
> -    return NO;

Same, is this also needed?
Comment 3 Alex Christensen 2017-04-13 11:51:41 PDT
Yep, they're both needed.  They solve different problems that also prevent the CMake build from working.