Bug 170813 - Add additional information when logging URL disposition in WebLoaderStrategy::scheduleLoad
Summary: Add additional information when logging URL disposition in WebLoaderStrategy:...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
Depends on:
Reported: 2017-04-13 10:46 PDT by Keith Rollin
Modified: 2017-04-18 15:28 PDT (History)
4 users (show)

See Also:

Patch (6.04 KB, patch)
2017-04-13 10:48 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2017-04-13 10:46:12 PDT
There are a few logging statements in WebLoaderStrategy::scheduleLoad that report, for example, "URL will be loaded as data". These statements also log the address of the frame doing the loading and the identifier of the resource. For consistency with other logging and to make scripted analysis of the logs more robust, also include the pageID and frameID in the logging.
Comment 1 Keith Rollin 2017-04-13 10:48:14 PDT
Created attachment 306996 [details]
Comment 2 Michael Catanzaro 2017-04-17 12:43:08 PDT
Comment on attachment 306996 [details]

PRIu64 is the best cross-platform way to print a uint64_t, so this looks right to me.

It technically needs an owner to approve it, though.
Comment 3 Keith Rollin 2017-04-18 14:45:48 PDT
Adding Antti and Alex, who both did previous reviews on this code.
Comment 4 WebKit Commit Bot 2017-04-18 15:28:14 PDT
Comment on attachment 306996 [details]

Clearing flags on attachment: 306996

Committed r215481: <http://trac.webkit.org/changeset/215481>
Comment 5 WebKit Commit Bot 2017-04-18 15:28:16 PDT
All reviewed patches have been landed.  Closing bug.