Clean up SharedBuffer public functions
Created attachment 306947 [details] Patch
Comment on attachment 306947 [details] Patch r=me with gtk build fixed.
Created attachment 306972 [details] Patch
Comment on attachment 306972 [details] Patch Attachment 306972 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3528364 New failing tests: webrtc/no-port-zero-in-upd-candidates.html
Created attachment 306983 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
http://trac.webkit.org/r215319
Comment on attachment 306972 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306972&action=review > Source/WebCore/platform/SharedBuffer.cpp:234 > -void SharedBuffer::append(const Vector<char>& data) > +void SharedBuffer::append(Vector<char>&& data) This is a strange change. The function never takes ownership of this Vector, yet the signature implies it might. Why?
I have plans to make it take ownership of a vector. Right now all the callers of this function give the Vector to the SharedBuffer, and I want to keep it that way.
(In reply to Alex Christensen from comment #8) > I have plans to make it take ownership of a vector. One good way to express that is a brief comment inside the implementation of the function. Helps make sure nobody reverses what you have done without understanding if you are away from the project for a while.
Adding comment in https://bugs.webkit.org/show_bug.cgi?id=170828