Bug 170785 - onnegotiationneeded should only be called once
Summary: onnegotiationneeded should only be called once
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-12 12:38 PDT by youenn fablet
Modified: 2017-04-13 09:39 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.71 KB, patch)
2017-04-12 12:41 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (979.50 KB, application/zip)
2017-04-12 14:06 PDT, Build Bot
no flags Details
Patch (8.14 KB, patch)
2017-04-12 16:41 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-04-12 12:38:21 PDT
onnegotiationneeded should only be called once while it is called twice with libwebrtc
Comment 1 youenn fablet 2017-04-12 12:41:57 PDT
Created attachment 306925 [details]
Patch
Comment 2 Build Bot 2017-04-12 14:06:48 PDT
Comment on attachment 306925 [details]
Patch

Attachment 306925 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3525608

New failing tests:
fast/mediastream/RTCPeerConnection-AddRemoveStream.html
fast/mediastream/RTCPeerConnection-onnegotiationneeded.html
Comment 3 Build Bot 2017-04-12 14:06:49 PDT
Created attachment 306932 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 4 youenn fablet 2017-04-12 16:41:22 PDT
Created attachment 306949 [details]
Patch
Comment 5 WebKit Commit Bot 2017-04-13 09:39:01 PDT
Comment on attachment 306949 [details]
Patch

Clearing flags on attachment: 306949

Committed r215321: <http://trac.webkit.org/changeset/215321>
Comment 6 WebKit Commit Bot 2017-04-13 09:39:03 PDT
All reviewed patches have been landed.  Closing bug.