Bug 170770 – [JSC] Clean up heap/MachineStackMarker by introducing HAVE(MACHINE_CONTEXT)

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[JSC] Clean up heap/MachineStackMarker by introducing USE(MACHINE_CONTEXT)

[Yusuke Suzuki]

Created attachment 306909 [details]
Patch

[Build Bot]

Comment on attachment 306909 [details]
Patch

Attachment 306909 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3524411

New failing tests:
webrtc/negotiatedneeded-event-addStream.html

[Build Bot]

Created attachment 306914 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Mark Lam]

Comment on attachment 306909 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306909&action=review

r=me with suggestion.

> Source/JavaScriptCore/heap/MachineStackMarker.cpp:235
> +#if OS(DARWIN) || OS(WINDOWS) || USE(MACHINE_CONTEXT)

Here, you explicitly  call out OS(DARWIN) even though USE(MACHINE_CONTEXT) already include OS(DARWIN).  Later below, you don't call out OS(DARWIN).  Let's be consistent.  How about we don't call out OS(DARWIN) explicitly?

> Source/JavaScriptCore/heap/MachineStackMarker.cpp:244
> +#if OS(DARWIN) || OS(WINDOWS) || USE(MACHINE_CONTEXT)

Ditto.

> Source/JavaScriptCore/heap/MachineStackMarker.cpp:254
> +#if OS(DARWIN) || OS(WINDOWS) || USE(MACHINE_CONTEXT)

Ditto.

[Yusuke Suzuki]

Comment on attachment 306909 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306909&action=review

Thanks!

>> Source/JavaScriptCore/heap/MachineStackMarker.cpp:235
>> +#if OS(DARWIN) || OS(WINDOWS) || USE(MACHINE_CONTEXT)
> 
> Here, you explicitly  call out OS(DARWIN) even though USE(MACHINE_CONTEXT) already include OS(DARWIN).  Later below, you don't call out OS(DARWIN).  Let's be consistent.  How about we don't call out OS(DARWIN) explicitly?

OK, let's drop OS(DARWIN) here.

>> Source/JavaScriptCore/heap/MachineStackMarker.cpp:244
>> +#if OS(DARWIN) || OS(WINDOWS) || USE(MACHINE_CONTEXT)
> 
> Ditto.

Fixed.

>> Source/JavaScriptCore/heap/MachineStackMarker.cpp:254
>> +#if OS(DARWIN) || OS(WINDOWS) || USE(MACHINE_CONTEXT)
> 
> Ditto.

Fixed.

[Yusuke Suzuki]

Committed r215269: <http://trac.webkit.org/changeset/215269>

[Yusuke Suzuki]

Committed r215270: <http://trac.webkit.org/changeset/215270>