Bug 170767 - [GStreamer] Dailymotion live stream videos don't play
Summary: [GStreamer] Dailymotion live stream videos don't play
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on: 169725
Blocks:
  Show dependency tree / graph
 
Reported: 2017-04-12 02:17 PDT by Carlos Garcia Campos
Modified: 2017-05-02 03:06 PDT (History)
3 users (show)

See Also:

Attachments
Patch (19.25 KB, patch)
2017-04-17 10:25 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Rebased patch (19.62 KB, patch)
2017-05-02 02:30 PDT, Carlos Garcia Campos 		svillar: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-04-12 02:17:41 PDT 
The video shows a message saying that an error occurred and nothing is played. For some reason we are getting a 404 for the hls parts.
Comment 1 Carlos Garcia Campos 2017-04-17 10:25:28 PDT 
Created attachment 307275 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-05-02 02:30:53 PDT 
Created attachment 308811 [details]
Rebased patch
Comment 3 Sergio Villar Senin 2017-05-02 02:46:09 PDT 
Comment on attachment 308811 [details]
Rebased patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308811&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:909
> +        priv->redirectedURI = WTFMove(resolvedURI);

This resolved/redirected naming is a bit confusing.

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:956
> +

I think this chunk of code deserves an explanation, it's pretty clear what it does but not why we need to do this.
Comment 4 Xabier Rodríguez Calvar 2017-05-02 02:58:11 PDT 
Comment on attachment 308811 [details]
Rebased patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308811&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1119
> +            m_resource = ResourceHandle::create(nullptr /*context*/, m_request, this, true, false);

Nit: I don't see the need of having /*context*/.
Comment 5 Carlos Garcia Campos 2017-05-02 03:06:08 PDT 
Committed r216067: <http://trac.webkit.org/changeset/216067>