Bug 170758 - Modernize vector adoption
Summary: Modernize vector adoption
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-11 18:26 PDT by Alex Christensen
Modified: 2017-04-12 08:40 PDT (History)
4 users (show)

See Also:


Attachments
Patch (20.78 KB, patch)
2017-04-11 18:28 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (21.64 KB, patch)
2017-04-12 01:41 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-04-11 18:26:18 PDT
Modernize vector adoption
Comment 1 Alex Christensen 2017-04-11 18:28:18 PDT
Created attachment 306882 [details]
Patch
Comment 2 Sam Weinig 2017-04-11 19:03:10 PDT
Comment on attachment 306882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306882&action=review

> Source/WebCore/platform/SharedBuffer.h:61
> +    WEBCORE_EXPORT static Ref<SharedBuffer> adoptVector(Vector<char>&&);

Seems like this could just be called create(Vector<char>&&)
Comment 3 Geoffrey Garen 2017-04-11 21:15:58 PDT
Comment on attachment 306882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306882&action=review

r=me

>> Source/WebCore/platform/SharedBuffer.h:61
>> +    WEBCORE_EXPORT static Ref<SharedBuffer> adoptVector(Vector<char>&&);
> 
> Seems like this could just be called create(Vector<char>&&)

👍 for create().
Comment 4 Alex Christensen 2017-04-12 01:41:52 PDT
Created attachment 306898 [details]
Patch
Comment 5 WebKit Commit Bot 2017-04-12 02:25:08 PDT
Comment on attachment 306898 [details]
Patch

Clearing flags on attachment: 306898

Committed r215262: <http://trac.webkit.org/changeset/215262>
Comment 6 WebKit Commit Bot 2017-04-12 02:25:09 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Yusuke Suzuki 2017-04-12 05:16:35 PDT
Committed r215266: <http://trac.webkit.org/changeset/215266>
Comment 8 Yusuke Suzuki 2017-04-12 05:33:09 PDT
Committed r215267: <http://trac.webkit.org/changeset/215267>
Comment 9 Alex Christensen 2017-04-12 08:40:26 PDT
Thanks Yusuke!