Bug 170754 – REGRESSION: LayoutTest webrtc/negotiatedneeded-event-addStream.html is frequently crashing

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryan Haddad]

LayoutTest webrtc/negotiatedneeded-event-addStream.html is frequently crashing

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r215247%20(605)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webrtc%2Fnegotiatedneeded-event-addStream.html

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.WebKit              	0x0000000108f2619e WTF::HashTableIterator<unsigned long long, WTF::KeyValuePair<unsigned long long, std::__1::unique_ptr<WebKit::NetworkRTCProvider::Resolver, std::__1::default_delete<WebKit::NetworkRTCProvider::Resolver> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, std::__1::unique_ptr<WebKit::NetworkRTCProvider::Resolver, std::__1::default_delete<WebKit::NetworkRTCProvider::Resolver> > > >, WTF::IntHash<unsigned long long>, WTF::HashMap<unsigned long long, std::__1::unique_ptr<WebKit::NetworkRTCProvider::Resolver, std::__1::default_delete<WebKit::NetworkRTCProvider::Resolver> >, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<std::__1::unique_ptr<WebKit::NetworkRTCProvider::Resolver, std::__1::default_delete<WebKit::NetworkRTCProvider::Resolver> > > >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> > WTF::HashTable<unsigned long long, WTF::KeyValuePair<unsigned long long, std::__1::unique_ptr<WebKit::NetworkRTCProvider::Resolver, std::__1::default_delete<WebKit::NetworkRTCProvider::Resolver> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, std::__1::unique_ptr<WebKit::NetworkRTCProvider::Resolver, std::__1::default_delete<WebKit::NetworkRTCProvider::Resolver> > > >, WTF::IntHash<unsigned long long>, WTF::HashMap<unsigned long long, std::__1::unique_ptr<WebKit::NetworkRTCProvider::Resolver, std::__1::default_delete<WebKit::NetworkRTCProvider::Resolver> >, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<std::__1::unique_ptr<WebKit::NetworkRTCProvider::Resolver, std::__1::default_delete<WebKit::NetworkRTCProvider::Resolver> > > >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> >::find<WTF::IdentityHashTranslator<WTF::HashMap<unsigned long long, std::__1::unique_ptr<WebKit::NetworkRTCProvider::Resolver, std::__1::default_delete<WebKit::NetworkRTCProvider::Resolver> >, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<std::__1::unique_ptr<WebKit::NetworkRTCProvider::Resolver, std::__1::default_delete<WebKit::NetworkRTCProvider::Resolver> > > >::KeyValuePairTraits, WTF::IntHash<unsigned long long> >, unsigned long long>(unsigned long long const&) + 10 (HashTable.h:1007)
1   com.apple.WebKit              	0x0000000108f24d63 WTF::HashMap<unsigned long long, std::__1::unique_ptr<WebKit::NetworkRTCProvider::Resolver, std::__1::default_delete<WebKit::NetworkRTCProvider::Resolver> >, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<std::__1::unique_ptr<WebKit::NetworkRTCProvider::Resolver, std::__1::default_delete<WebKit::NetworkRTCProvider::Resolver> > > >::take(unsigned long long const&) + 27 (HashTable.h:378)
2   com.apple.WebKit              	0x0000000108f24a64 WebKit::NetworkRTCProvider::resolvedName(__CFHost*, CFHostInfoType, CFStreamError const*, void*) + 64 (memory:2721)
3   com.apple.CFNetwork           	0x00007fffa5d02125 ClassicHostDelegate::hostInfoCallback(HostBase*, __CFString const*, __CFError*) + 155
4   com.apple.CFNetwork           	0x00007fffa5d01b79 HostBase::invokeCallback(__CFString const*) + 155
5   com.apple.CFNetwork           	0x00007fffa5d019e5 DispatchHost::processPending() + 129
6   com.apple.CoreFoundation      	0x00007fffa69988d1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
7   com.apple.CoreFoundation      	0x00007fffa6979be7 __CFRunLoopDoSources0 + 423
8   com.apple.CoreFoundation      	0x00007fffa6979156 __CFRunLoopRun + 934
9   com.apple.CoreFoundation      	0x00007fffa6978b54 CFRunLoopRunSpecific + 420
10  com.apple.Foundation          	0x00007fffa83ab612 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 277
11  com.apple.Foundation          	0x00007fffa83ab4ea -[NSRunLoop(NSRunLoop) run] + 76
12  libxpc.dylib                  	0x00007fffbc1d989b _xpc_objc_main + 731
13  libxpc.dylib                  	0x00007fffbc1d82e4 xpc_main + 494
14  com.apple.WebKit.Networking   	0x0000000108e38695 main + 492
15  libdyld.dylib                 	0x00007fffbbf75255 start + 1

[Radar WebKit Bug Importer]

<rdar://problem/31573169>

[youenn fablet]

Created attachment 306924 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 306924 [details]
Patch for landing

Clearing flags on attachment: 306924

Committed r215278: <http://trac.webkit.org/changeset/215278>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[youenn fablet]

Let's fix it

[youenn fablet]

Test is no longer crashing probably to change in the way we stop resolvers.