Disable outdated WritableStream API
<rdar://problem/31446233>
Created attachment 306849 [details] Patch
Comment on attachment 306849 [details] Patch rs=me
Committed r215250: <http://trac.webkit.org/changeset/215250>
I am surprised some tests in LayoutTests/streams do not fail. Were they disabled? Are we sure WritableStream is disabled? I'll update my build sometimes today and will have a look at it at that time.
WritableStream does not seem disabled. Probably related to WTF/wtf/Platform.h which defines ENABLE_WRITABLE_STREAM_API to 1 if not already defined. The same applies to ReadableStream and ReadableByteStream.
To fix things, we could probably: - replace WRITABLE_STREAM_API, READABLE_STREAM_API and READABLE_BYTE_STREAM_API by STREAMS_API, enabled by default. - Add a writable_stream and readable_byte_stream runtime flags, enabled only for rwt.
Reopening to attach new patch.
Created attachment 307184 [details] Patch
Created attachment 307186 [details] Patch
Created attachment 307188 [details] Patch
Created attachment 307189 [details] Patch
Created attachment 307201 [details] Patch
I verified that WritableStream is undefined and ReadableStream{{type: "bytes"}) is throwing.
(In reply to youenn fablet from comment #14) > I verified that WritableStream is undefined and ReadableStream{{type: > "bytes"}) is throwing. except in rwt/drt
Created attachment 307204 [details] Win tentative build fix
What's the value in having the ENABLE_STREAMS_API at all? Is anyone planning on not shipping with it?
Comment on attachment 307204 [details] Win tentative build fix Attachment 307204 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3542606 New failing tests: compositing/absolute-inside-out-of-view-fixed.html
Created attachment 307213 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
(In reply to Sam Weinig from comment #17) > What's the value in having the ENABLE_STREAMS_API at all? Is anyone planning > on not shipping with it? Looking at Source/WTF/FeatureDefines.h, the default ENABLE_READABLE_STREAM_API is 0 for win, although this might be overridden somewhere else in win build system, not sure about that. I also got feedback from time to time that I broke the build for some non-upstreamed ports that were disabling ENABLE_STREAMS_API. I agree we should consider removing it.
Comment on attachment 307204 [details] Win tentative build fix Clearing flags on attachment: 307204 Committed r215429: <http://trac.webkit.org/changeset/215429>
All reviewed patches have been landed. Closing bug.