Bug 170747 – Link preload HTMLPreloadScanner support

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yoav Weiss]

Link preload HTMLPreloadScanner support

[Yoav Weiss]

Created attachment 306853 [details]
Patch

[Yoav Weiss]

Created attachment 306857 [details]
Patch

[Yoav Weiss]

Friendly ping :)

[youenn fablet]

Comment on attachment 306857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306857&action=review

> Source/WebCore/html/parser/HTMLPreloadScanner.cpp:149
> +        std::optional<CachedResource::Type> type = resourceType();

Use auto maybe?

> LayoutTests/http/tests/preload/preloadscanner_download_resources.html:7
> +    shouldBeTrue("internals.isPreloaded('../resources/dummy.js');");

Can you exit early if window.intrrnals is undefined?

> LayoutTests/http/tests/preload/preloadscanner_download_resources.html:8
> +    shouldBeTrue("internals.isPreloaded('../resources/dummy.css');");

Exit with a proper message..,

[Yoav Weiss]

Created attachment 308891 [details]
Patch

[Yoav Weiss]

(In reply to youenn fablet from comment #4)
> Comment on attachment 306857 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=306857&action=review
> 
> > Source/WebCore/html/parser/HTMLPreloadScanner.cpp:149
> > +        std::optional<CachedResource::Type> type = resourceType();
> 
> Use auto maybe?

done
> 
> > LayoutTests/http/tests/preload/preloadscanner_download_resources.html:7
> > +    shouldBeTrue("internals.isPreloaded('../resources/dummy.js');");
> 
> Can you exit early if window.intrrnals is undefined?

done
> 
> > LayoutTests/http/tests/preload/preloadscanner_download_resources.html:8
> > +    shouldBeTrue("internals.isPreloaded('../resources/dummy.css');");
> 
> Exit with a proper message..,

Not sure what you mean, as `shouldBeTrue` has no parameter for a more meaningful message. Can you elaborate?

[Yoav Weiss]

Created attachment 308949 [details]
Patch

[Yoav Weiss]

Comment on attachment 308949 [details]
Patch

Added a failure message when internals is not available. Thanks for reviewing! :)

[WebKit Commit Bot]

Comment on attachment 308949 [details]
Patch

Clearing flags on attachment: 308949

Committed r216143: <http://trac.webkit.org/changeset/216143>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.