Bug 170741 – webkitpy: Ignore previously launched pid when system is under stress

• Status: RESOLVED
• Resolution: CONFIGURATION CHANGED
• Component: Tools / Tests

[Jonathan Bedard]

When launching apps on an iOS Simulator, xcrun simctl launch will sometimes return the pid of the previous process if that process is still being torn down.  When the system is stressed, the race conditions which exist here can get worse.  Mitigate these issues by checking if the returned PID is a new PID in SimulatorProcess.

[Radar WebKit Bug Importer]

<rdar://problem/31560432>

[Jonathan Bedard]

Created attachment 306835 [details]
Patch

[David Kilzer (:ddkilzer)]

Comment on attachment 306835 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306835&action=review

r=me

> Tools/Scripts/webkitpy/port/simulator_process.py:96
> +            raise Exception('Faild to launch {}, kept receiving old PID'.format(os.path.basename(self._cmd[0])))

Jonathan says this should be a RuntimeException.

Adding a blank space before the "try:" line would make this easier to read.

[Jonathan Bedard]

Created attachment 307036 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 307036 [details]
Patch for landing

Clearing flags on attachment: 307036

Committed r215346: <http://trac.webkit.org/changeset/215346>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Jonathan Bedard]

Follow up fix in <http://trac.webkit.org/changeset/215361>.

[Jonathan Bedard]

Another follow up fix in <http://trac.webkit.org/changeset/215363>.

[Ryan Haddad]

Reverted r215363 for reason:

This change causes LayoutTests to exit early with crashes.

Committed r215367: <http://trac.webkit.org/changeset/215367>

[Jonathan Bedard]

Addressed Ryan's rollout in <http://trac.webkit.org/changeset/215374>.

[Ryan Haddad]

Reverted r215374 for reason:

This change causes LayoutTests to exit early with crashes on Sierra.

Committed r215380: <http://trac.webkit.org/changeset/215380>

[Jonathan Bedard]

If <https://trac.webkit.org/changeset/215416/webkit> fixes this problem, I will roll-out all of the other changes.

I think <https://trac.webkit.org/changeset/215416/webkit> is the root cause.

[Jonathan Bedard]

Reverted r215346 and r215361 for reason:

The problem these changes were fixing was addressed in <https://trac.webkit.org/changeset/215416/webkit>.

Committed r215470: <http://trac.webkit.org/changeset/215470>