Bug 170739 – Add a preference for the media resource buffering time

• Status: NEW
• Component: New Bugs

[Alex Christensen]

Add a preference for the media resource buffering time

[Alex Christensen]

Created attachment 306833 [details]
Patch

[Alex Christensen]

rdar://problem/31485485

[Sam Weinig]

Comment on attachment 306833 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306833&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm:590
> +- (double)_mediaResourceMaximumBufferingTime

I think the suffix Duration, rather than Time, would be better.

> Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm:251
> +    parameters.mediaResourceMaximumBufferingTime = Seconds(m_defaultPageGroup->preferences().mediaResourceMaximumBufferingTime());

Seems weird/wrong to have webpreferences affect WebProcess creation, since a single web process can have web pages with different webpreferences.  It also looks like you aren't handling the preference changing after the process is created.

[Alex Christensen]

I agree that it's icky, but this is a consequence of the WebResourceLoader being process global in the WebProcess.  And it's only temporary, so I'll remove it soon.  I'll change the suffix, though.

[Alex Christensen]

Created attachment 306843 [details]
Patch

[Alex Christensen]

Created attachment 306851 [details]
Patch

[Alex Christensen]

Comment on attachment 306851 [details]
Patch

This patch is a step in the wrong direction, but it will allow me to do local testing easier.