Add a preference for the media resource buffering time
Created attachment 306833 [details]
Comment on attachment 306833 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=306833&action=review
> +- (double)_mediaResourceMaximumBufferingTime
I think the suffix Duration, rather than Time, would be better.
> + parameters.mediaResourceMaximumBufferingTime = Seconds(m_defaultPageGroup->preferences().mediaResourceMaximumBufferingTime());
Seems weird/wrong to have webpreferences affect WebProcess creation, since a single web process can have web pages with different webpreferences. It also looks like you aren't handling the preference changing after the process is created.
I agree that it's icky, but this is a consequence of the WebResourceLoader being process global in the WebProcess. And it's only temporary, so I'll remove it soon. I'll change the suffix, though.
Created attachment 306843 [details]
Created attachment 306851 [details]
Comment on attachment 306851 [details]
This patch is a step in the wrong direction, but it will allow me to do local testing easier.