Bug 170738 – Web Inspector: remove dead code for switching Toolbar display options

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

We don't allow switching between icons and text any more. We can remove this code.

[Blaze Burg]

Created attachment 306834 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 306834 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306834&action=review

> Source/WebInspectorUI/ChangeLog:9
> +        Keep in the code that manages the display modes, but remove the context
> +        menu code since it's dead and never shown.

Why keep in the code managing display modes if they can't be reached? Seems like a bunch of CSS and Enums that could be removed.

[Matt Baker]

Comment on attachment 306834 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306834&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/Main.js:279
> +    this.toolbar = new WebInspector.Toolbar(document.getElementById("toolbar"), null);

The null navigationItems argument can be removed.

[Matt Baker]

Oops Joe beat me to it.

[Blaze Burg]

Created attachment 306855 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 306855 [details]
Patch

r=me

[Build Bot]

Comment on attachment 306855 [details]
Patch

Attachment 306855 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3520770

New failing tests:
webrtc/negotiatedneeded-event-addStream.html

[Build Bot]

Created attachment 306876 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[WebKit Commit Bot]

Comment on attachment 306855 [details]
Patch

Clearing flags on attachment: 306855

Committed r216628: <http://trac.webkit.org/changeset/216628>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.