Bug 170725 – [WebCore][JSC] ResourceUsageData.{timeOfNextEdenCollection,timeOfNextFullCollection} should be MonotonicTime

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Yusuke Suzuki]

...

[Yusuke Suzuki]

Created attachment 306822 [details]
Patch

[Yusuke Suzuki]

Created attachment 306823 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 306823 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306823&action=review

> Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:481
> +    MonotonicTime now = MonotonicTime::now();

Inside the timer, we usually use MonotonicTime. Thus, using MonotonicTime to calculate the difference should be appropriate instead of WallTime.

[Sam Weinig]

Comment on attachment 306823 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306823&action=review

> Source/WTF/wtf/MonotonicTime.h:49
> +    constexpr MonotonicTime() { }

Want to make a few tests that test constexpr MonotonicTime?

[Yusuke Suzuki]

Comment on attachment 306823 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306823&action=review

Thanks!

> Source/JavaScriptCore/heap/GCActivityCallback.cpp:81
> +    return MonotonicTime::fromRawSeconds(CFRunLoopTimerGetNextFireDate(m_timer.get()));

Oops, I need to change this thing to MonotonicTime::now() + (CFRunLoopTimerGetNextFireDate(m_timer.get()) - CFAbsoluteTimeGetCurrent()).

>> Source/WTF/wtf/MonotonicTime.h:49
>> +    constexpr MonotonicTime() { }
> 
> Want to make a few tests that test constexpr MonotonicTime?

Added.

[Yusuke Suzuki]

Committed r215241: <http://trac.webkit.org/changeset/215241>

[Ryan Haddad]

(In reply to Yusuke Suzuki from comment #6)
> Committed r215241: <http://trac.webkit.org/changeset/215241>

This change broke macOS and iOS builds:
https://build.webkit.org/builders/Apple%20Sierra%20Release%20%28Build%29/builds/694
https://build.webkit.org/builders/Apple%20iOS%2010%20Release%20%28Build%29/builds/543

[Yusuke Suzuki]

Committed r215244: <http://trac.webkit.org/changeset/215244>