Bug 170712 - MediaStream id should be equal to msid
Summary: MediaStream id should be equal to msid
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-10 19:12 PDT by youenn fablet
Modified: 2017-04-11 10:06 PDT (History)
6 users (show)

See Also:


Attachments
Patch (48.47 KB, patch)
2017-04-10 19:22 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (999.63 KB, application/zip)
2017-04-10 20:42 PDT, Build Bot
no flags Details
Patch (53.61 KB, patch)
2017-04-10 21:32 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (926.78 KB, application/zip)
2017-04-10 23:12 PDT, Build Bot
no flags Details
Patch for landing (53.75 KB, patch)
2017-04-11 09:39 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-04-10 19:12:09 PDT
This is not the case for remote MediaStreams.
Comment 1 youenn fablet 2017-04-10 19:22:29 PDT
Created attachment 306768 [details]
Patch
Comment 2 Build Bot 2017-04-10 20:42:50 PDT
Comment on attachment 306768 [details]
Patch

Attachment 306768 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3514649

New failing tests:
fast/mediastream/RTCPeerConnection-setRemoteDescription-offer.html
fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid.html
fast/mediastream/RTCPeerConnection-inspect-offer.html
fast/mediastream/RTCPeerConnection-inspect-answer.html
fast/mediastream/RTCPeerConnection-media-setup-single-dialog.html
fast/mediastream/RTCPeerConnection-setLocalDescription-offer.html
fast/mediastream/RTCPeerConnection-legacy-stream-based-api.html
Comment 3 Build Bot 2017-04-10 20:42:51 PDT
Created attachment 306770 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 4 youenn fablet 2017-04-10 21:32:55 PDT
Created attachment 306774 [details]
Patch
Comment 5 Build Bot 2017-04-10 23:12:50 PDT
Comment on attachment 306774 [details]
Patch

Attachment 306774 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3515148

New failing tests:
webrtc/negotiatedneeded-event-addStream.html
Comment 6 Build Bot 2017-04-10 23:12:51 PDT
Created attachment 306781 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 7 Eric Carlson 2017-04-11 08:50:02 PDT
Comment on attachment 306774 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306774&action=review

> Source/WebCore/Modules/mediastream/MediaStream.cpp:70
> +        trackPrivates.append(&track->privateTrack());

Nit: uncheckedAppend?
Comment 8 youenn fablet 2017-04-11 09:39:51 PDT
Created attachment 306824 [details]
Patch for landing
Comment 9 youenn fablet 2017-04-11 09:40:06 PDT
Thanks for the review

(In reply to Eric Carlson from comment #7)
> Comment on attachment 306774 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=306774&action=review
> 
> > Source/WebCore/Modules/mediastream/MediaStream.cpp:70
> > +        trackPrivates.append(&track->privateTrack());
> 
> Nit: uncheckedAppend?

Done
Comment 10 WebKit Commit Bot 2017-04-11 10:06:57 PDT
Comment on attachment 306824 [details]
Patch for landing

Clearing flags on attachment: 306824

Committed r215238: <http://trac.webkit.org/changeset/215238>
Comment 11 WebKit Commit Bot 2017-04-11 10:06:59 PDT
All reviewed patches have been landed.  Closing bug.