Bug 170712 – MediaStream id should be equal to msid

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[youenn fablet]

This is not the case for remote MediaStreams.

[youenn fablet]

Created attachment 306768 [details]
Patch

[Build Bot]

Comment on attachment 306768 [details]
Patch

Attachment 306768 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3514649

New failing tests:
fast/mediastream/RTCPeerConnection-setRemoteDescription-offer.html
fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid.html
fast/mediastream/RTCPeerConnection-inspect-offer.html
fast/mediastream/RTCPeerConnection-inspect-answer.html
fast/mediastream/RTCPeerConnection-media-setup-single-dialog.html
fast/mediastream/RTCPeerConnection-setLocalDescription-offer.html
fast/mediastream/RTCPeerConnection-legacy-stream-based-api.html

[Build Bot]

Created attachment 306770 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[youenn fablet]

Created attachment 306774 [details]
Patch

[Build Bot]

Comment on attachment 306774 [details]
Patch

Attachment 306774 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3515148

New failing tests:
webrtc/negotiatedneeded-event-addStream.html

[Build Bot]

Created attachment 306781 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Eric Carlson]

Comment on attachment 306774 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306774&action=review

> Source/WebCore/Modules/mediastream/MediaStream.cpp:70
> +        trackPrivates.append(&track->privateTrack());

Nit: uncheckedAppend?

[youenn fablet]

Created attachment 306824 [details]
Patch for landing

[youenn fablet]

Thanks for the review

(In reply to Eric Carlson from comment #7)
> Comment on attachment 306774 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=306774&action=review
> 
> > Source/WebCore/Modules/mediastream/MediaStream.cpp:70
> > +        trackPrivates.append(&track->privateTrack());
> 
> Nit: uncheckedAppend?

Done

[WebKit Commit Bot]

Comment on attachment 306824 [details]
Patch for landing

Clearing flags on attachment: 306824

Committed r215238: <http://trac.webkit.org/changeset/215238>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.