Bug 170710 - Activate WebRTC data channel tests for WK1
Summary: Activate WebRTC data channel tests for WK1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-10 18:05 PDT by youenn fablet
Modified: 2017-04-11 10:27 PDT (History)
4 users (show)

See Also:

Attachments
Patch (10.97 KB, patch)
2017-04-10 18:08 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (10.86 KB, patch)
2017-04-11 09:43 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-04-10 18:05:25 PDT 
Activate WebRTC data channel tests for WK1
Comment 1 youenn fablet 2017-04-10 18:08:37 PDT 
Created attachment 306765 [details]
Patch
Comment 2 Eric Carlson 2017-04-11 08:07:22 PDT 
Comment on attachment 306765 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306765&action=review

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:67
> +    ASSERT(client.factory());

Won't the m_peerConnectionFactory assignment above have crashed already if the factory is NULL?
Comment 3 youenn fablet 2017-04-11 09:43:55 PDT 
Created attachment 306826 [details]
Patch for landing
Comment 4 youenn fablet 2017-04-11 09:47:13 PDT 
(In reply to Eric Carlson from comment #2)
> Comment on attachment 306765 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=306765&action=review
> 
> > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:67
> > +    ASSERT(client.factory());
> 
> Won't the m_peerConnectionFactory assignment above have crashed already if
> the factory is NULL?

This is undefined behavior so it should be fine but we should not do that.
I removed the ASSERT.

Hopefully, we can make factory() returning a reference now.
I'll do this in a follow-up
Comment 5 WebKit Commit Bot 2017-04-11 10:27:13 PDT 
Comment on attachment 306826 [details]
Patch for landing

Clearing flags on attachment: 306826

Committed r215239: <http://trac.webkit.org/changeset/215239>
Comment 6 WebKit Commit Bot 2017-04-11 10:27:15 PDT 
All reviewed patches have been landed.  Closing bug.