Bug 170710 – Activate WebRTC data channel tests for WK1

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

Activate WebRTC data channel tests for WK1

[youenn fablet]

Created attachment 306765 [details]
Patch

[Eric Carlson]

Comment on attachment 306765 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306765&action=review

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:67
> +    ASSERT(client.factory());

Won't the m_peerConnectionFactory assignment above have crashed already if the factory is NULL?

[youenn fablet]

Created attachment 306826 [details]
Patch for landing

[youenn fablet]

(In reply to Eric Carlson from comment #2)
> Comment on attachment 306765 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=306765&action=review
> 
> > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:67
> > +    ASSERT(client.factory());
> 
> Won't the m_peerConnectionFactory assignment above have crashed already if
> the factory is NULL?

This is undefined behavior so it should be fine but we should not do that.
I removed the ASSERT.

Hopefully, we can make factory() returning a reference now.
I'll do this in a follow-up

[WebKit Commit Bot]

Comment on attachment 306826 [details]
Patch for landing

Clearing flags on attachment: 306826

Committed r215239: <http://trac.webkit.org/changeset/215239>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.