Bug 170696 - Have parseRevisionProperty use default repo name as the buildbot key.
Summary: Have parseRevisionProperty use default repo name as the buildbot key.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-10 15:08 PDT by Kocsen Chung
Modified: 2017-04-10 20:44 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.51 KB, patch)
2017-04-10 15:13 PDT, Kocsen Chung
no flags Details | Formatted Diff | Diff
Patch (2.50 KB, patch)
2017-04-10 17:01 PDT, Kocsen Chung
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kocsen Chung 2017-04-10 15:08:38 PDT
Have parseRevisionProperty use default repo name as the buildbot key.
Comment 1 Kocsen Chung 2017-04-10 15:13:05 PDT
Created attachment 306749 [details]
Patch
Comment 2 Daniel Bates 2017-04-10 16:23:23 PDT
Comment on attachment 306749 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306749&action=review

> Tools/ChangeLog:9
> +        buildobt data. That is no longer necessary as we can make a safe assumption

buildobt => Buildbot

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:208
> +            var key = repositoryName;

Instead of default initializing these variables and then overwriting them for OpenSiurce I suggest that we leave them hninitialized here and remove the "else if" For Internal.
Comment 3 Kocsen Chung 2017-04-10 17:01:23 PDT
Created attachment 306759 [details]
Patch
Comment 4 Kocsen Chung 2017-04-10 17:12:04 PDT
Comment on attachment 306759 [details]
Patch

Thanks Dan, for the review. commit-queue ?
Comment 5 WebKit Commit Bot 2017-04-10 20:34:00 PDT
Comment on attachment 306759 [details]
Patch

Clearing flags on attachment: 306759

Committed r215215: <http://trac.webkit.org/changeset/215215>
Comment 6 WebKit Commit Bot 2017-04-10 20:34:02 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Lucas Forschler 2017-04-10 20:44:40 PDT
I've updated the buildbot repo as of 8:45 pacific time.