Bug 170680 – [GTK] Opening a popup menu does not pre-select the active item

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Adrian Perez]

Created attachment 306698 [details]
Good: GtkComboBox popped up after clicking

When clicking a GtkComboBox, the popup menu appears with the
“active” item below the mouse pointer *and* also pre-selected
(e.g. blue background and white text for the Adwaita theme).

We try to mimic this behaviour in popup menus from web pages,
and WebKitGTK+ already uses a GtkMenu to provide the same look,
replicating some of the code in “gtkcombobox.c” to calculate the
positioning for the menu. Unfortunately, the “active” item does 
*NOT* get pre-selected in the WebKitGTK+ popup menus.

[Adrian Perez]

Created attachment 306700 [details]
Bad: WebKitGTK+ popup menu popped up after clicking

[Adrian Perez]

If the explanation is not completely clear, please do check the
attached images, IMHO they greatly help to understand how our
popups are not behaving exactly the same as the ones from GTK+
we are trying to mimic.

[Adrian Perez]

Created attachment 306703 [details]
Patch

[Adrian Perez]

(In reply to Adrian Perez from comment #2)
> If the explanation is not completely clear, please do check the
> attached images, IMHO they greatly help to understand how our
> popups are not behaving exactly the same as the ones from GTK+
> we are trying to mimic.

A patch for having the active item pre-selected on popup is now
attached to bug #170553 :-)

[Michael Catanzaro]

Comment on attachment 306703 [details]
Patch

I wonder if this will break layout tests. Please watch the bots.

[WebKit Commit Bot]

Comment on attachment 306703 [details]
Patch

Clearing flags on attachment: 306703

Committed r215188: <http://trac.webkit.org/changeset/215188>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.