Bug 170677 - REGRESSION (r214403): fast/events/drag-to-navigate.html and fast/events/only-valid-drop-targets-receive-file-drop.html failing
Summary: REGRESSION (r214403): fast/events/drag-to-navigate.html and fast/events/only-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-10 09:14 PDT by Wenson Hsieh
Modified: 2017-04-10 14:31 PDT (History)
4 users (show)

See Also:


Attachments
Patch (7.14 KB, patch)
2017-04-10 09:24 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Patch (7.17 KB, patch)
2017-04-10 09:32 PDT, Wenson Hsieh
thorton: review+
Details | Formatted Diff | Diff
Patch for landing (7.17 KB, patch)
2017-04-10 10:09 PDT, Wenson Hsieh
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (7.17 KB, patch)
2017-04-10 10:16 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-04-10 09:14:20 PDT
<rdar://problem/31512633>
Comment 1 Wenson Hsieh 2017-04-10 09:24:13 PDT
Created attachment 306691 [details]
Patch
Comment 2 Wenson Hsieh 2017-04-10 09:32:50 PDT
Created attachment 306692 [details]
Patch
Comment 3 Tim Horton 2017-04-10 09:42:36 PDT
Comment on attachment 306692 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306692&action=review

> LayoutTests/fast/events/drag-to-navigate.html:1
> +<!-- webkit-test-runner [ enableDragDestinationActionLoad=true ] -->

Technically no reason this needs to be a thing like this, could just be JS API (doesn't need to be known before load) but ... I guess it's OK?
Comment 4 Wenson Hsieh 2017-04-10 10:03:33 PDT
Comment on attachment 306692 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306692&action=review

>> LayoutTests/fast/events/drag-to-navigate.html:1
>> +<!-- webkit-test-runner [ enableDragDestinationActionLoad=true ] -->
> 
> Technically no reason this needs to be a thing like this, could just be JS API (doesn't need to be known before load) but ... I guess it's OK?

True, but I think in this case, TestOptions are appropriate since there aren't really cases where this behavior needs to change at runtime (i.e. it's more like a configuration or initialization param rather than a behavior to be performed).
Comment 5 Wenson Hsieh 2017-04-10 10:09:39 PDT
Created attachment 306699 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2017-04-10 10:10:54 PDT
Comment on attachment 306699 [details]
Patch for landing

Rejecting attachment 306699 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 306699, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/3512117
Comment 7 Wenson Hsieh 2017-04-10 10:16:43 PDT
Created attachment 306701 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2017-04-10 10:59:01 PDT
Comment on attachment 306701 [details]
Patch for landing

Clearing flags on attachment: 306701

Committed r215189: <http://trac.webkit.org/changeset/215189>