Bug 170676 – Cache small media resources in disk cache

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Antti Koivisto]

We don't currently cache media resources persistently to avoid filling the cache. We should allow caching of reasonably sized media resources.

[Radar WebKit Bug Importer]

<rdar://problem/31532649>

[Antti Koivisto]

Created attachment 306689 [details]
patch

[Build Bot]

Comment on attachment 306689 [details]
patch

Attachment 306689 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3511890

New failing tests:
http/tests/cache/disk-cache/disk-cache-media-small.html

[Build Bot]

Created attachment 306696 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 306689 [details]
patch

Attachment 306689 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3511931

New failing tests:
http/tests/cache/disk-cache/disk-cache-media-small.html

[Build Bot]

Created attachment 306702 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Antti Koivisto]

Created attachment 306705 [details]
patch

[Antti Koivisto]

Created attachment 306724 [details]
patch

[Build Bot]

Comment on attachment 306724 [details]
patch

Attachment 306724 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3512841

New failing tests:
http/tests/cache/disk-cache/disk-cache-media-small.html

[Build Bot]

Created attachment 306735 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Antti Koivisto]

Created attachment 306792 [details]
patch

[Build Bot]

Comment on attachment 306792 [details]
patch

Attachment 306792 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3516981

New failing tests:
http/tests/cache/disk-cache/disk-cache-media-small.html

[Build Bot]

Created attachment 306814 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 306792 [details]
patch

Attachment 306792 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3517397

New failing tests:
http/tests/cache/disk-cache/disk-cache-media-small.html

[Build Bot]

Created attachment 306819 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Antti Koivisto]

Created attachment 306893 [details]
patch

[Andreas Kling]

Comment on attachment 306893 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306893&action=review

r=me

> Source/WebCore/loader/MediaResourceLoader.h:58
> +    Vector<ResourceResponse> responsesForTesting() const { return m_responsesForTesting; }

This could return a const Vector<ResourceResponse>& I suppose, though if it's just for testing it matters less.

> Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:238
> +    if (StringView(contentRange).left(6) != ASCIILiteral("bytes "))
> +        return { };

I would write this using contentRange.startsWith().

[Antti Koivisto]

https://trac.webkit.org/r215263

[Antti Koivisto]

Made the test less flaky in https://trac.webkit.org/r215317