I realized that JSObject::put doesn't really need an attributes parameter, so I'm working to get rid of it.
Created attachment 18764 [details]
work in progress
Created attachment 19001 [details]
patch (passes all regression tests, but ignores attributes in put call in C API)
This is *so* close to being ready to review. The remaining issue is what we should do about the C API. Do we want to give the public put call the ability to assign attributes, and if so, how should we do this while preserving the rest of the semantics? Maybe it should do some combination of getDirect, putDirect, and put?
Geoff, I'd like to land this.
What do you think we should do about the attribute argument to JSObjectSetProperty? I think we discussed it but I forgot what we decided.
Created attachment 19307 [details]
Comment on attachment 19307 [details]
r=me with the change we discussed on IRC
Committed revision 30534.