Bug 170668 – test262: test262/test/built-ins/NativeErrors/EvalError/proto.js

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Joseph Pecoraro]

test262/test/built-ins/NativeErrors/EvalError/proto.js

Simplified:
assert( Object.getPrototypeOf(EvalError) === Error )

Spec:
https://tc39.github.io/ecma262/#sec-properties-of-the-nativeerror-constructors

> 19.5.6.2Properties of the NativeError Constructors
>
> The value of the [[Prototype]] internal slot of a NativeError
> constructor is the intrinsic object %Error%.

This affects all NativeError Constructors (EvalError, RangeError, TypeError, etc.)

Notes:
- Chrome passes this test
  Object.getPrototypeOf(EvalError) === Error
- Safari, Firefox, and Edge are all currently:
  Object.getPrototypeOf(EvalError) === Function.prototype

Given 3 browsers have same behavior we might want to consider changing the spec.

[Joseph Pecoraro]

Created attachment 306670 [details]
[PATCH] Proposed Fix

Again, we may want to change the spec, so setting cq- for now.

[Build Bot]

Comment on attachment 306670 [details]
[PATCH] Proposed Fix

Attachment 306670 [details] did not pass jsc-ews (mac):
Output: http://webkit-queues.webkit.org/results/3510265

New failing tests:
ChakraCore.yaml/ChakraCore/test/Lib/error.js.default

[Build Bot]

Comment on attachment 306670 [details]
[PATCH] Proposed Fix

Attachment 306670 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3510365

New failing tests:
ietestcenter/Javascript/15.2.3.2-2-16.html
ietestcenter/Javascript/15.2.3.2-2-14.html
ietestcenter/Javascript/15.2.3.2-2-12.html
ietestcenter/Javascript/15.2.3.2-2-13.html
ietestcenter/Javascript/15.2.3.2-2-15.html
ietestcenter/Javascript/15.2.3.2-2-17.html

[Build Bot]

Created attachment 306673 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 306670 [details]
[PATCH] Proposed Fix

Attachment 306670 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3510368

New failing tests:
ietestcenter/Javascript/15.2.3.2-2-16.html
ietestcenter/Javascript/15.2.3.2-2-14.html
ietestcenter/Javascript/15.2.3.2-2-12.html
ietestcenter/Javascript/15.2.3.2-2-13.html
ietestcenter/Javascript/15.2.3.2-2-15.html
ietestcenter/Javascript/15.2.3.2-2-17.html

[Build Bot]

Created attachment 306674 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 306670 [details]
[PATCH] Proposed Fix

Attachment 306670 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3510369

New failing tests:
ietestcenter/Javascript/15.2.3.2-2-16.html
ietestcenter/Javascript/15.2.3.2-2-14.html
ietestcenter/Javascript/15.2.3.2-2-12.html
ietestcenter/Javascript/15.2.3.2-2-13.html
ietestcenter/Javascript/15.2.3.2-2-15.html
ietestcenter/Javascript/15.2.3.2-2-17.html

[Build Bot]

Created attachment 306676 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 306670 [details]
[PATCH] Proposed Fix

Attachment 306670 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3510378

New failing tests:
ietestcenter/Javascript/15.2.3.2-2-16.html
ietestcenter/Javascript/15.2.3.2-2-14.html
ietestcenter/Javascript/15.2.3.2-2-12.html
ietestcenter/Javascript/15.2.3.2-2-13.html
ietestcenter/Javascript/15.2.3.2-2-15.html
ietestcenter/Javascript/15.2.3.2-2-17.html

[Build Bot]

Created attachment 306677 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Joseph Pecoraro]

Created attachment 306780 [details]
[PATCH] Proposed Fix

Still wondering if we should just change the spec here.

[Keith Miller]

Comment on attachment 306780 [details]
[PATCH] Proposed Fix

I think it's pretty reasonable in the current spec. This change means that EvalError.__proto__.prototype === EvalError.prototype.__proto__, which should probably be true.

[Keith Miller]

r=me.

[Joseph Pecoraro]

Comment on attachment 306780 [details]
[PATCH] Proposed Fix

Makes sense to me.

[WebKit Commit Bot]

Comment on attachment 306780 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 306780

Committed r215312: <http://trac.webkit.org/changeset/215312>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.