Bug 170666 - update-webkit-dependency should report $response->message for diagnose
Summary: update-webkit-dependency should report $response->message for diagnose
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-09 22:34 PDT by Fujii Hironori
Modified: 2017-04-10 10:35 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.04 KB, patch)
2017-04-09 22:40 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2017-04-09 22:34:18 PDT 
update-webkit-dependency should report $response->message for diagnose

To investigate bugs such like Bug 170664 and Bug 170665.
Comment 1 Fujii Hironori 2017-04-09 22:40:17 PDT 
Created attachment 306657 [details]
Patch
Comment 2 Fujii Hironori 2017-04-09 22:41:17 PDT 
Before this change:

> C:\webkit\ga>perl Tools\Scripts\update-webkit-auxiliary-libs
> Checking for newer version of WebKitAuxiliaryLibrary.zip...
> Could not access https://developer.apple.com/opensource/internet/WebKitAuxiliaryLibrary.zip:
> Content-Type: text/plain
> Client-Date: Mon, 10 Apr 2017 05:24:15 GMT
> Client-Warning: Internal response
> 
> Please ensure that https://developer.apple.com/opensource/internet/WebKitAuxiliaryLibrary.zip is reachable and that Perl can use LWP::Simple to connect to HTTPS URLs.
> You may have to run "$ cpan LWP::Protocol::https".
> No existing version of WebKitAuxiliaryLibrary to fall back to.
> Died at Tools\Scripts\update-webkit-auxiliary-libs line 42.

After this change:

> C:\webkit\ga>perl Tools\Scripts\update-webkit-auxiliary-libs
> Checking for newer version of WebKitAuxiliaryLibrary.zip...
> Could not access https://developer.apple.com/opensource/internet/WebKitAuxiliaryLibrary.zip:
> SSL upgrade failed: hostname verification failed
> Content-Type: text/plain
> Client-Date: Mon, 10 Apr 2017 05:27:58 GMT
> Client-Warning: Internal response
> 
> Please ensure that https://developer.apple.com/opensource/internet/WebKitAuxiliaryLibrary.zip is reachable and that Perl can use LWP::Simple to connect to HTTPS URLs.
> You may have to run "$ cpan LWP::Protocol::https".
> No existing version of WebKitAuxiliaryLibrary to fall back to.
> Died at Tools\Scripts\update-webkit-auxiliary-libs line 42.

The line of "SSL upgrade failed: hostname verification failed" has been added.
Comment 3 WebKit Commit Bot 2017-04-10 10:35:23 PDT 
Comment on attachment 306657 [details]
Patch

Clearing flags on attachment: 306657

Committed r215186: <http://trac.webkit.org/changeset/215186>
Comment 4 WebKit Commit Bot 2017-04-10 10:35:24 PDT 
All reviewed patches have been landed.  Closing bug.