Bug 170662 – [WTF] Annotate Seconds' member functions and operators with constexpr

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[WTF] Annotate Seconds' member functions and operators with constexpr

[Yusuke Suzuki]

Created attachment 306638 [details]
Patch

[Yusuke Suzuki]

Created attachment 306639 [details]
Patch

[Yusuke Suzuki]

Created attachment 306640 [details]
Patch

[Daniel Bates]

Comment on attachment 306640 [details]
Patch

r=me

[Yusuke Suzuki]

Comment on attachment 306640 [details]
Patch

Thanks!

[Daniel Bates]

Comment on attachment 306640 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306640&action=review

> Source/WTF/wtf/MathExtras.h:200
> +    return (value >= static_cast<double>(max)) ? max : ((value <= static_cast<double>(min)) ? min : static_cast<T>(value));

I take to that we must support one or more compilers that do not support C++14 extended constexpr and hence had to rewrite this function to have a single return statement.

[Yusuke Suzuki]

Comment on attachment 306640 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306640&action=review

>> Source/WTF/wtf/MathExtras.h:200
>> +    return (value >= static_cast<double>(max)) ? max : ((value <= static_cast<double>(min)) ? min : static_cast<T>(value));
> 
> I take to that we must support one or more compilers that do not support C++14 extended constexpr and hence had to rewrite this function to have a single return statement.

Right. At least, WebKitGTK+ needs to support GCC 4.9 now, which does not support C++14 relaxed constexpr.
Once C++14 relaxed constexpr is allowed, the above code will be much simplified.

[WebKit Commit Bot]

Comment on attachment 306640 [details]
Patch

Clearing flags on attachment: 306640

Committed r215169: <http://trac.webkit.org/changeset/215169>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

Thanks for doing this. I’ll use it in my next patch.