Bug 170653 – WTR: Avoid conversion from platform image to WKImage and then to platform image again when dumping pixel results

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Garcia Campos]

When dumping pixels from a web view snapshot, we create a platform image that is then converted to a WKImage, which is a ShareableBitmap, so the image is rendered into a graphics context. Then we immediately extract the platform image back from the WKImage to dump the pixels. We could avoid that conversion by taking the web snapshot from TestInvocation::dumpPixelsAndCompareWithExpected().

[Carlos Garcia Campos]

Created attachment 306611 [details]
Patch

[Build Bot]

Comment on attachment 306611 [details]
Patch

Attachment 306611 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3505055

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 306615 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Carlos Garcia Campos]

hmm, it seems the iOS changes are not correct, I'll try to figure out

[Carlos Garcia Campos]

Created attachment 306668 [details]
Patch for landing

I think the problem in iOS is that we were releasing CARenderServerBufferRef too early, so I've added a callback to CGDataProviderCreateWithData and moved the call to CARenderServerDestroyBuffer there.

[Carlos Garcia Campos]

Created attachment 306672 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 306672 [details]
Patch for landing

Clearing flags on attachment: 306672

Committed r215176: <http://trac.webkit.org/changeset/215176>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.