A multi-line multi-line comment with HTML Closing Comment should treat trailing content like HTML Closing Comment (single line comment) Test: 1/* */--> This should be a comment Expected: 1 Result: SyntaxError Test: test262/test/annexB/language/comments/multi-line-html-close.js
Created attachment 306586 [details] [PATCH] Proposed Fix
Comment on attachment 306586 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=306586&action=review > Source/JavaScriptCore/parser/Lexer.cpp:1994 > + if ((m_atLineStart || m_terminator) && m_current == '>') { I might be able to just drop m_atLineStart entirely and just use m_terminator.
Comment on attachment 306586 [details] [PATCH] Proposed Fix Yes, I think I can drop the entire variable. Existing tests pass I'm going to add a few more.
> Yes, I think I can drop the entire variable. Existing tests pass I'm going > to add a few more. Nope I lied, existing tests did not pass. Leaving patch as it is!
Comment on attachment 306586 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=306586&action=review >> Source/JavaScriptCore/parser/Lexer.cpp:1994 >> + if ((m_atLineStart || m_terminator) && m_current == '>') { > > I might be able to just drop m_atLineStart entirely and just use m_terminator. Nope. Other tests failed. Patch is reviewable as is.
Ping reviewers
Comment on attachment 306586 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=306586&action=review r=me. > LayoutTests/js/parser-xml-close-comment-expected.txt:1 > +Test to ensure correct handling of --> as a single line comment when at the beginning of a line or preceeded by a multi-line comment Wow, I didn't know this was a thing... weird
Comment on attachment 306586 [details] [PATCH] Proposed Fix Clearing flags on attachment: 306586 Committed r215235: <http://trac.webkit.org/changeset/215235>
All reviewed patches have been landed. Closing bug.