Bug 170646 - Remove use of strcpy from JSC
Summary: Remove use of strcpy from JSC
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
Depends on:
Reported: 2017-04-08 15:20 PDT by Oliver Hunt
Modified: 2017-04-09 16:47 PDT (History)
6 users (show)

See Also:

Patch (1.95 KB, patch)
2017-04-08 15:22 PDT, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (1.79 KB, patch)
2017-04-08 19:13 PDT, Oliver Hunt
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2017-04-08 15:20:41 PDT
Remove use of strcpy from JSC
Comment 1 Oliver Hunt 2017-04-08 15:22:33 PDT
Created attachment 306583 [details]
Comment 2 Oliver Hunt 2017-04-08 15:23:16 PDT
Unbelievably trivial patch :)
Comment 3 Mark Lam 2017-04-08 15:29:04 PDT
Comment on attachment 306583 [details]

r=me, but can you fix the GTK build failure?  Is strlcpy available for all posix?
Comment 4 Oliver Hunt 2017-04-08 19:13:07 PDT
Created attachment 306593 [details]
Comment 5 Mark Lam 2017-04-08 19:25:58 PDT
Comment on attachment 306593 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=306593&action=review

r=me with ChangeLog comment fixed.

> Source/JavaScriptCore/ChangeLog:10
> +        Replace the use of strcpy with strlcpy as strcpy keeps
> +        on tripping various analyser warnings even though its
> +        trivially safe in this case.

Your comment needs to be updated.
Comment 6 Oliver Hunt 2017-04-09 16:47:22 PDT
Committed r215168: <http://trac.webkit.org/changeset/215168>