Bug 170631 – Web Inspector: navigation sidebar says "No Search Results" when a slow search is in progress

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

Steps to reproduce:

1. Remote debug a (slow/old) device
2. Go to the HTML5 spec-in-one-page
3. Search for something overbroad, like 'page'
=> Says "No Results" then flashes and shows results some time later when they start to arrive

We should fix this so that we say "Searching [spinner]" while the backend does the search.

[Blaze Burg]

<rdar://problem/29473874>

[Devin Rousso]

Created attachment 361856 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 361856 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361856&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js:272
> -                DOMAgent.discardSearchResults(this._domSearchIdentifier);
> +                countPromise(DOMAgent.discardSearchResults(this._domSearchIdentifier));

We shouldn't need to wait on this one, it is just clearing old search data, not affecting the current search(es).

[Devin Rousso]

Created attachment 362967 [details]
Patch

[Devin Rousso]

Created attachment 362968 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 362968 [details]
Patch

Clearing flags on attachment: 362968

Committed r242080: <https://trac.webkit.org/changeset/242080>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.