Bug 170627 - WebRTC outgoing muted video sources should send black frames
Summary: WebRTC outgoing muted video sources should send black frames
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-07 16:51 PDT by youenn fablet
Modified: 2017-05-15 17:41 PDT (History)
4 users (show)

See Also:

Attachments
Patch (8.31 KB, patch)
2017-05-11 11:57 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (51.78 KB, patch)
2017-05-15 16:34 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (8.53 KB, patch)
2017-05-15 16:55 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (8.53 KB, patch)
2017-05-15 16:59 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-04-07 16:51:32 PDT 
It is not clear whether we should send black frames or just send one black frame and stop.
Submitted https://github.com/w3c/mediacapture-main/issues/441
Comment 1 Radar WebKit Bug Importer 2017-04-07 16:52:35 PDT 
<rdar://problem/31513869>
Comment 2 youenn fablet 2017-05-11 11:57:13 PDT 
Created attachment 309743 [details]
Patch
Comment 3 Eric Carlson 2017-05-15 13:42:09 PDT 
Comment on attachment 309743 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309743&action=review

> Source/WebCore/ChangeLog:11
> +        Instead of sending one black frame and then another one asynchronously, we use the timer to send a black frame every second when outgoing source is muted.

Nit: this line should be wrapped to a more reasonable length.

> LayoutTests/webrtc/video-mute.html:90
> +	return Promise.reject("This test requires internals API");

Nit: indentation
Comment 4 youenn fablet 2017-05-15 16:34:09 PDT 
Created attachment 310179 [details]
Patch for landing
Comment 5 youenn fablet 2017-05-15 16:55:58 PDT 
Created attachment 310187 [details]
Patch for landing
Comment 6 youenn fablet 2017-05-15 16:59:53 PDT 
Created attachment 310189 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2017-05-15 17:41:54 PDT 
Comment on attachment 310189 [details]
Patch for landing

Clearing flags on attachment: 310189

Committed r216892: <http://trac.webkit.org/changeset/216892>
Comment 8 WebKit Commit Bot 2017-05-15 17:41:55 PDT 
All reviewed patches have been landed.  Closing bug.