Bug 170627 – WebRTC outgoing muted video sources should send black frames

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[youenn fablet]

It is not clear whether we should send black frames or just send one black frame and stop.
Submitted https://github.com/w3c/mediacapture-main/issues/441

[Radar WebKit Bug Importer]

<rdar://problem/31513869>

[youenn fablet]

Created attachment 309743 [details]
Patch

[Eric Carlson]

Comment on attachment 309743 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309743&action=review

> Source/WebCore/ChangeLog:11
> +        Instead of sending one black frame and then another one asynchronously, we use the timer to send a black frame every second when outgoing source is muted.

Nit: this line should be wrapped to a more reasonable length.

> LayoutTests/webrtc/video-mute.html:90
> +	return Promise.reject("This test requires internals API");

Nit: indentation

[youenn fablet]

Created attachment 310179 [details]
Patch for landing

[youenn fablet]

Created attachment 310187 [details]
Patch for landing

[youenn fablet]

Created attachment 310189 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 310189 [details]
Patch for landing

Clearing flags on attachment: 310189

Committed r216892: <http://trac.webkit.org/changeset/216892>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.