WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 136989
170621
WebKitJavascriptResult binding not introspectable
https://bugs.webkit.org/show_bug.cgi?id=170621
Summary
WebKitJavascriptResult binding not introspectable
Jack Goofy
Reported
2017-04-07 15:01:08 PDT
This is a follow up for
https://bugs.webkit.org/show_bug.cgi?id=136989
The following patch allows to use the GObject Introspection for Python to get result from WebKitJavascriptResult js_result = web_view.run_javascript_finish(res) js_result.to_string()
Attachments
Diff for adding the to_string function for GObject Introspection in WebKitJavascriptResult
(2.85 KB, patch)
2017-04-07 15:08 PDT
,
Jack Goofy
mcatanzaro
: review-
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from ews116 for mac-elcapitan
(1.58 MB, application/zip)
2017-04-07 16:25 PDT
,
Build Bot
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Jack Goofy
Comment 1
2017-04-07 15:08:08 PDT
Created
attachment 306540
[details]
Diff for adding the to_string function for GObject Introspection in WebKitJavascriptResult
Build Bot
Comment 2
2017-04-07 15:10:28 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See
http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Build Bot
Comment 3
2017-04-07 16:25:37 PDT
Comment on
attachment 306540
[details]
Diff for adding the to_string function for GObject Introspection in WebKitJavascriptResult
Attachment 306540
[details]
did not pass mac-debug-ews (mac): Output:
http://webkit-queues.webkit.org/results/3492902
New failing tests: imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-worker.html
Build Bot
Comment 4
2017-04-07 16:25:39 PDT
Created
attachment 306548
[details]
Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Carlos Garcia Campos
Comment 5
2018-03-06 09:38:13 PST
*** This bug has been marked as a duplicate of
bug 136989
***
Michael Catanzaro
Comment 6
2018-03-06 10:52:57 PST
Comment on
attachment 306540
[details]
Diff for adding the to_string function for GObject Introspection in WebKitJavascriptResult Carlos, do we still want this? r- because it needs API tests (but I wouldn't spend any more effort on this unless Carlos recommends it)
Michael Catanzaro
Comment 7
2018-03-06 10:53:39 PST
(In reply to Carlos Garcia Campos from
comment #5
)
> > *** This bug has been marked as a duplicate of
bug 136989
***
Ah, I missed this. This means it's not needed anymore. ;)
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug