Bug 170611 - Web Inspector: DOM/XHR breakpoint tree elements shouldn't persist their represented objects
Summary: Web Inspector: DOM/XHR breakpoint tree elements shouldn't persist their repre...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-07 12:06 PDT by Matt Baker
Modified: 2017-04-07 12:31 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.17 KB, patch)
2017-04-07 12:12 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2017-04-07 12:06:09 PDT 
Summary:
DOM/XHR breakpoint tree elements shouldn't persist their represented objects.

Steps to Reproduce:
1. Inspector > Debugger tab
2. Select something from Sources
3. Select the global "All Requests" XHR breakpoint
4. Refresh the page
  => After a delay (1-2s):
     - Global XHR breakpoint is selected
     - Debugger tab content view changes to the DOMTree
     - Assertion:

[Error] Assertion Failed: createFromRepresentedObject and resolvedRepresentedObjectForRepresentedObject are out of sync for type – "XHRBreakpoint"
	contentViewForRepresentedObject (ContentView.js:194)
	showContentViewForRepresentedObject (ContentBrowser.js:146)
	showDefaultContentViewForTreeElement (NavigationSidebarPanel.js:195:83)
	_checkElementsForPendingViewStateCookie (NavigationSidebarPanel.js:710)
	finalAttemptToRestoreViewStateFromCookie (NavigationSidebarPanel.js:248)
	finalAttemptToRestoreViewStateFromCookie
Comment 1 Radar WebKit Bug Importer 2017-04-07 12:07:07 PDT 
<rdar://problem/31506161>
Comment 2 Matt Baker 2017-04-07 12:12:06 PDT 
Created attachment 306525 [details]
Patch
Comment 3 Joseph Pecoraro 2017-04-07 12:16:53 PDT 
Comment on attachment 306525 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2017-04-07 12:31:09 PDT 
Comment on attachment 306525 [details]
Patch

Clearing flags on attachment: 306525

Committed r215113: <http://trac.webkit.org/changeset/215113>
Comment 5 WebKit Commit Bot 2017-04-07 12:31:10 PDT 
All reviewed patches have been landed.  Closing bug.