Bug 170609 – Web Inspector: WebSockets: Transferred size is incorrect

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Transferred size for WebSocket messages is currently incorrect. https://github.com/WebKit/webkit/blob/add8695eff1c434696a6db324fa5daca1bfd4813/Source/WebInspectorUI/UserInterface/Models/WebSocketResource.js#L75

    this.increaseSize(data.length, elapsedTime);

data is a string. data.length does not represent it's size.

I think we should send payload size from the backend. We currently don't do this.

In WebSocket protocol, payload length must be included with each message:
https://developer.mozilla.org/en-US/docs/Web/API/WebSockets_API/Writing_WebSocket_servers#Format

[Nikita Vasilyev]

If for some reason the backend change isn't feasible, we should replace

    data.length

with

    new TextEncoder("utf-8").encode(data).length

[Nikita Vasilyev]

Created attachment 306560 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/31544506>

[Nikita Vasilyev]

Comment on attachment 306560 [details]
Patch

This patch doesn't have any tests. I'll combine it with Bug 169175 - Web Inspector: Add tests for webSocketFrameSent and webSocketFrameReceived.

[Matt Baker]

Comment on attachment 306560 [details]
Patch

Looks good! r- for now, because we should include a test for the protocol change.

[Matt Baker]

(In reply to Nikita Vasilyev from comment #4)
> Comment on attachment 306560 [details]
> Patch
> 
> This patch doesn't have any tests. I'll combine it with Bug 169175 - Web
> Inspector: Add tests for webSocketFrameSent and webSocketFrameReceived.

Since it's a protocol change I think a test should be included in this patch.

[Nikita Vasilyev]

Fixed in https://trac.webkit.org/changeset/215388/webkit.