Bug 170603 - Missing conversion from window to content coordinates when adjusting unobscured content rects for input view
Summary: Missing conversion from window to content coordinates when adjusting unobscur...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-07 09:04 PDT by Wenson Hsieh
Modified: 2017-04-08 02:42 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.59 KB, patch)
2017-04-07 09:45 PDT, Wenson Hsieh 		simon.fraser: review+
Details | Formatted Diff | Diff
Patch for landing (3.57 KB, patch)
2017-04-07 11:59 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-04-07 09:04:49 PDT 
In -[WKContentView _computeUnobscuredContentRectRespectingInputViewBounds:unobscuredContentRect:inputViewBounds:scale:], inputViewBounds is in window coordinates, while unobscuredContentRect is specified in content coordinates. Before doing math with inputViewBounds, we need to convert it to content view coordinates.
Comment 1 Wenson Hsieh 2017-04-07 09:45:31 PDT 
Created attachment 306512 [details]
Patch
Comment 2 Wenson Hsieh 2017-04-07 11:59:39 PDT 
Created attachment 306524 [details]
Patch for landing
Comment 3 WebKit Commit Bot 2017-04-07 12:17:39 PDT 
Comment on attachment 306524 [details]
Patch for landing

Clearing flags on attachment: 306524

Committed r215111: <http://trac.webkit.org/changeset/215111>