Bug 170601 - REGRESSION (r214553): Allow layout-tests to be run from Xcode without re-directing stdout, stdin and stderr
Summary: REGRESSION (r214553): Allow layout-tests to be run from Xcode without re-dire...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-07 08:22 PDT by Jonathan Bedard
Modified: 2017-04-07 12:07 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.86 KB, patch)
2017-04-07 09:10 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (1.90 KB, patch)
2017-04-07 09:19 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2017-04-07 08:22:28 PDT 
<http://trac.webkit.org/changeset/214553> always expects to use TCP for stdout, stdin and stderr on iOS simulators.  Both WebKitTestRunnerApp.app and DumpRenderTree.app should allow for stdout, stdin and stderr to be routed to their normal file handles for Xcode debugging if the PORT environment is not defined.
Comment 1 Jonathan Bedard 2017-04-07 08:28:59 PDT 
<rdar://problem/31492696>
Comment 2 Jonathan Bedard 2017-04-07 09:10:47 PDT 
Created attachment 306510 [details]
Patch
Comment 3 Simon Fraser (smfr) 2017-04-07 09:14:48 PDT 
Comment on attachment 306510 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306510&action=review

> Tools/TestRunnerShared/IOSLayoutTestCommunication.cpp:54
>      int port = atoi(getenv("PORT"));

Why not use portFromEnvironment here?
Comment 4 Jonathan Bedard 2017-04-07 09:19:30 PDT 
Created attachment 306511 [details]
Patch
Comment 5 WebKit Commit Bot 2017-04-07 12:07:36 PDT 
Comment on attachment 306511 [details]
Patch

Clearing flags on attachment: 306511

Committed r215109: <http://trac.webkit.org/changeset/215109>
Comment 6 WebKit Commit Bot 2017-04-07 12:07:38 PDT 
All reviewed patches have been landed.  Closing bug.