Bug 170590 - [GTK] Update the Fedora dependencies for WebKitGTK+
Summary: [GTK] Update the Fedora dependencies for WebKitGTK+
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Gtk (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-07 01:15 PDT by Xan Lopez
Modified: 2017-04-17 07:47 PDT (History)
7 users (show)

See Also:


Attachments
Add missing dependencies (2.11 KB, patch)
2017-04-07 01:17 PDT, Xan Lopez
mcatanzaro: review-
Details | Formatted Diff | Diff
Update jhbuild dependencies for WebRTC (2.53 KB, patch)
2017-04-17 01:20 PDT, Xan Lopez
no flags Details | Formatted Diff | Diff
Add WebRTC dependencies (2.53 KB, patch)
2017-04-17 06:53 PDT, Xan Lopez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2017-04-07 01:15:56 PDT
There's tons of basic gstreamer codecs missing in the default build in Fedora.
Comment 1 Xan Lopez 2017-04-07 01:17:06 PDT
Created attachment 306476 [details]
Add missing dependencies
Comment 2 Michael Catanzaro 2017-04-07 05:02:13 PDT
Comment on attachment 306476 [details]
Add missing dependencies

When we update the dependency list for any of these operating systems, we should check to see if the dependencies are needed on other operating systems as well. Does the script install these dependencies for both Debian and Arch?

You don't have to actually test the script on the other OSes. Just see if the lists contain similarly-named packages, and check https://www.debian.org/distrib/packages and https://www.archlinux.org/packages/ to find the right name of the package to add.
Comment 3 Carlos Alberto Lopez Perez 2017-04-07 05:09:19 PDT
For Debian the support is complete (yested by myself)
And I guess Adrian (CC'ed) can complete the arch one arch.
Comment 4 Carlos Alberto Lopez Perez 2017-04-07 05:10:47 PDT
(In reply to Carlos Alberto Lopez Perez from comment #3)
> For Debian the support is complete (tested by myself)

Well, not 100% sure if its complete because of the script or because I have a lot of dev packages already installed :)
Comment 5 Carlos Alberto Lopez Perez 2017-04-07 05:22:32 PDT
Comment on attachment 306476 [details]
Add missing dependencies

View in context: https://bugs.webkit.org/attachment.cgi?id=306476&action=review

> Tools/gtk/install-dependencies:366
>      packages=" \
> +        alsa-lib-devel \

Is this needed for something useful?

> Tools/gtk/install-dependencies:410
> +        libsrtp-devel \
> +        libtheora-devel \
>          libv4l-devel \
> +        libvorbis-devel \
> +        libvpx-devel \
>          libwebp-devel \
>          libwayland-client-devel \
>          libwayland-server-devel \
>          mesa-libGL-devel \
>          ninja-build \
>          openssl-devel \
> +        opus-devel \

This are missing on the debian codepath. This are the names:
libsrtp0-dev
libtheora-dev
libvorbis-dev
libvpx-dev
libopus-dev
Comment 6 Michael Catanzaro 2017-04-07 06:55:24 PDT
Comment on attachment 306476 [details]
Add missing dependencies

Please update the Arch and Debian package lists too!
Comment 7 Michael Catanzaro 2017-04-07 07:05:17 PDT
Arch package names are alsa-lib, libtheora, libvorbis, libvpx, opus.

I don't think Arch has librtsp, so unless I'm wrong it would need to be added to JHBuild.
Comment 8 Adrian Perez 2017-04-07 08:10:45 PDT
(In reply to Michael Catanzaro from comment #7)
> Arch package names are alsa-lib, libtheora, libvorbis, libvpx, opus.
> 
> I don't think Arch has librtsp, so unless I'm wrong it would need to be
> added to JHBuild.

That's right, and librtsp is not even in the AUR (Arch User Repository),
so it would be good to have it in the JHBuild.
Comment 9 Adrian Perez 2017-04-07 08:13:50 PDT
(In reply to Adrian Perez from comment #8)
> (In reply to Michael Catanzaro from comment #7)
> > Arch package names are alsa-lib, libtheora, libvorbis, libvpx, opus.
> > 
> > I don't think Arch has librtsp, so unless I'm wrong it would need to be
> > added to JHBuild.
> 
> That's right, and librtsp is not even in the AUR (Arch User Repository),
> so it would be good to have it in the JHBuild.

JFTR, if you want to check for other packages in the AUR, you can do so
at https://aur.archlinux.org/. It has packages contributed by users, that
have are source-based and are built for installing. If a package is there
I would not add it to the JHBuild unless we need a very specific version,
because developers (and most Arch users) won't mind having to build a few
packages from AUR.
Comment 10 Carlos Alberto Lopez Perez 2017-04-07 08:24:54 PDT
(In reply to Adrian Perez from comment #8)
> (In reply to Michael Catanzaro from comment #7)
> > Arch package names are alsa-lib, libtheora, libvorbis, libvpx, opus.
> > 
> > I don't think Arch has librtsp, so unless I'm wrong it would need to be
> > added to JHBuild.
> 
> That's right, and librtsp is not even in the AUR (Arch User Repository),
> so it would be good to have it in the JHBuild.

Is this significantly easier than packaging it for the AUR?
Comment 11 Adrian Perez 2017-04-07 08:58:55 PDT
(In reply to Carlos Alberto Lopez Perez from comment #10)
> (In reply to Adrian Perez from comment #8)
> > (In reply to Michael Catanzaro from comment #7)
> > > Arch package names are alsa-lib, libtheora, libvorbis, libvpx, opus.
> > > 
> > > I don't think Arch has librtsp, so unless I'm wrong it would need to be
> > > added to JHBuild.
> > 
> > That's right, and librtsp is not even in the AUR (Arch User Repository),
> > so it would be good to have it in the JHBuild.
> 
> Is this significantly easier than packaging it for the AUR?

Haha, we had a confusion here... You all kept writing “libRTSp”, when
originally what we are wondering about is “libSRTp”. This one is already
in Arch:

  https://www.archlinux.org/packages/extra/x86_64/libsrtp/

(It is a dependency of gst-plugins-bad in Arch!)
Comment 12 Xan Lopez 2017-04-17 01:20:53 PDT
Created attachment 307260 [details]
Update jhbuild dependencies for WebRTC

Drop ALSA, we are not sure it's needed.

Add all missing modules to Fedora and libvpx and libsrtp to Arch and Debian.
Comment 13 Adrian Perez 2017-04-17 06:42:54 PDT
Comment on attachment 307260 [details]
Update jhbuild dependencies for WebRTC

View in context: https://bugs.webkit.org/attachment.cgi?id=307260&action=review

Informal review here: I'd r+ once the two typos mentioned are fixed.

The typos are understandable, it easy to get letter swapped with the
mish-mash of acronyms.

(For me it's good to think that letters “RT” have to go together
because of “Real-Time”. I hope this mnemotechnic rule helps :P)

> Tools/gtk/install-dependencies:131
> +        libsrpt0-dev \

This should be libsrtp0-dev -- https://packages.debian.org/jessie/libsrtp0-dev

> Tools/gtk/install-dependencies:278
> +        libsrpt \

Ditto: libsrtp
Comment 14 Xan Lopez 2017-04-17 06:53:17 PDT
Created attachment 307269 [details]
Add WebRTC dependencies
Comment 15 WebKit Commit Bot 2017-04-17 07:47:07 PDT
Comment on attachment 307269 [details]
Add WebRTC dependencies

Clearing flags on attachment: 307269

Committed r215409: <http://trac.webkit.org/changeset/215409>
Comment 16 WebKit Commit Bot 2017-04-17 07:47:10 PDT
All reviewed patches have been landed.  Closing bug.