Bug 170575 - Web Inspector: Hangs when loading under SpeculativeLoad::shouldCaptureExtraNetworkLoadMetrics
Summary: Web Inspector: Hangs when loading under SpeculativeLoad::shouldCaptureExtraNe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-06 16:58 PDT by Joseph Pecoraro
Modified: 2017-04-06 17:40 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.25 KB, patch)
2017-04-06 17:01 PDT, Joseph Pecoraro 		bburg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-04-06 16:58:27 PDT 
Hangs when loading under SpeculativeLoad::shouldCaptureExtraNetworkLoadMetrics with Inspector open.

This is infinite looping because m_networkLoad is (this).

#if USE(NETWORK_SESSION)
bool SpeculativeLoad::shouldCaptureExtraNetworkLoadMetrics() const
{
    return m_networkLoad->shouldCaptureExtraNetworkLoadMetrics();
}
#endif

We can just drop this method and get the right behavior.
Comment 1 Joseph Pecoraro 2017-04-06 17:01:09 PDT 
Created attachment 306439 [details]
[PATCH] Proposed Fix
Comment 2 BJ Burg 2017-04-06 17:02:03 PDT 
Comment on attachment 306439 [details]
[PATCH] Proposed Fix

rs=🤣
Comment 3 Joseph Pecoraro 2017-04-06 17:40:07 PDT 
<https://trac.webkit.org/changeset/215078/webkit>