Bug 170551 - Web Inspector: RTL: layout issues in Open Resource Dialog
Summary: Web Inspector: RTL: layout issues in Open Resource Dialog
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Brian Burg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-06 10:23 PDT by Brian Burg
Modified: 2017-04-27 16:09 PDT (History)
3 users (show)

See Also:


Attachments
ltr - before (393.25 KB, image/png)
2017-04-06 10:23 PDT, Brian Burg
no flags Details
RTL - before (270.82 KB, image/png)
2017-04-06 10:23 PDT, Brian Burg
no flags Details
RTL - after (320.32 KB, image/png)
2017-04-06 10:26 PDT, Brian Burg
no flags Details
Proposed Fix (5.68 KB, patch)
2017-04-06 10:28 PDT, Brian Burg
mattbaker: review+
bburg: commit-queue?
Details | Formatted Diff | Diff
with flex:none (542.58 KB, image/png)
2017-04-27 16:06 PDT, Brian Burg
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2017-04-06 10:23:03 PDT
Need to flip icons and padding.
Comment 1 Brian Burg 2017-04-06 10:23:24 PDT
Created attachment 306401 [details]
ltr - before
Comment 2 Brian Burg 2017-04-06 10:23:36 PDT
Created attachment 306402 [details]
RTL - before
Comment 3 Brian Burg 2017-04-06 10:26:16 PDT
Created attachment 306404 [details]
RTL - after
Comment 4 Brian Burg 2017-04-06 10:28:11 PDT
Created attachment 306405 [details]
Proposed Fix
Comment 5 Matt Baker 2017-04-06 10:39:30 PDT
(In reply to Brian Burg from comment #1)
> Created attachment 306401 [details]
> ltr - before

The vertical alignment of the icon feels off. It's possible some of the other recent RTL style changes affected "large" tree outlines, since its a more rare use case.
Comment 6 Matt Baker 2017-04-06 10:44:48 PDT
The list item item height is too small for the large-style tree outline. This patch it not to blame.
Comment 7 Matt Baker 2017-04-06 11:05:28 PDT
Setting `flex: none` on the tree items fixes the vertical size issue.
Comment 8 Matt Baker 2017-04-06 11:07:59 PDT
Comment on attachment 306405 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=306405&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.css:159
>  .open-resource-dialog > .tree-outline .item {

Please confirm that adding `flex: none` here fixes the tree element sizing issue.
Comment 9 Brian Burg 2017-04-27 16:06:44 PDT
Created attachment 308469 [details]
with flex:none
Comment 10 Brian Burg 2017-04-27 16:09:21 PDT
Committed r215902: <http://trac.webkit.org/changeset/215902>