[GTK] [2.14.5] WebKitGTK+ always loads system-wide installed plugins

[Alberto Garcia]

One Debian user reports that WebKitGTK+ is always loading system-wide installed plugins, even if the "enable-plugins" setting is explicitly set to FALSE.

This is apparently causing crashes in some of this WebKitGTK+ apps.

You can see that with this command:

   strace /usr/lib/x86_64-linux-gnu/webkit2gtk-4.0/MiniBrowser --enable-plugins=FALSE <some-URL>

Original bug report here: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=859100

[Jérémy Lal]

Hello,

if the pluginInfoStore is not preloaded elsewhere, the behavior i'm seeing might be just right there:

--- a/Source/WebKit2/UIProcess/WebPageProxy.cpp
+++ b/Source/WebKit2/UIProcess/WebPageProxy.cpp
@@ -1315,8 +1315,9 @@
 
 #if ENABLE(NETSCAPE_PLUGIN_API)
     String newMimeType = mimeType;
+    if (!m_preferences->pluginsEnabled()) return false;
     PluginModuleInfo plugin = m_process->processPool().pluginInfoStore().findPlugin(newMimeType, URL());
-    if (!plugin.path.isNull() && m_preferences->pluginsEnabled())
+    if (!plugin.path.isNull())
         return true;
 #endif // ENABLE(NETSCAPE_PLUGIN_API)

[Michael Catanzaro]

That patch looks sane to me. Now does it work? :)

[Jérémy Lal]

It doesn't. I'll try something else later.

[Adrian Perez]

(In reply to Jérémy Lal from comment #3)
> It doesn't. I'll try something else later.

Hi Jérémy! By any chance, did you get to try something else in the end?

[Carlos Garcia Campos]

Plugins are no longer supported.