Bug 170539 - [GTK] Fix build with MEDIA_CAPTURE enabled
Summary: [GTK] Fix build with MEDIA_CAPTURE enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords:
: 170542 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-04-06 00:21 PDT by Adrian Perez
Modified: 2017-04-06 02:58 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.63 KB, patch)
2017-04-06 02:08 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2017-04-06 00:21:45 PDT 
Enabling MEDIA_CAPTURE (for exaple with “build-webkit --media-capture”) causes
compilation to fail with the following error.

  .../Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDeprecated.cpp:
    In function ‘gboolean webkit_dom_html_input_element_get_capture(WebKitDOMHTMLInputElement*)’:
  .../Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDeprecated.cpp:168:40:
    error: ‘MediaCaptureTypeNone’ was not declared in this scope
       return item->mediaCaptureType() != MediaCaptureTypeNone;
                                          ^~~~~~~~~~~~~~~~~~~~

The definition is still around, but this code should be using
“WebCore::MediaCaptureTypeNone”. I'll be posting a patch soon.
Comment 1 Adrian Perez 2017-04-06 02:08:21 PDT 
Created attachment 306370 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-04-06 02:57:16 PDT 
*** Bug 170542 has been marked as a duplicate of this bug. ***
Comment 3 WebKit Commit Bot 2017-04-06 02:58:21 PDT 
Comment on attachment 306370 [details]
Patch

Clearing flags on attachment: 306370

Committed r215009: <http://trac.webkit.org/changeset/215009>
Comment 4 WebKit Commit Bot 2017-04-06 02:58:23 PDT 
All reviewed patches have been landed.  Closing bug.