Bug 170527 - Remove run-jsc-stress-tests benign warning about otool '-S' switch
Summary: Remove run-jsc-stress-tests benign warning about otool '-S' switch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-05 16:34 PDT by Joseph Pecoraro
Modified: 2017-04-05 17:13 PDT (History)
3 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.29 KB, patch)
2017-04-05 16:35 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-04-05 16:34:02 PDT 
Summary:
Remove run-jsc-stress-tests benign warning about otool '-S' switch.

The switch appears to not be necessary, since jscPath is a binary not a library:

	-S print the table of contents of a library

Steps to reproduce:
1. $ run-jsc-stress-tests --release JSCTests/wasm.yaml
  => Output includes an error:
  Using the following jsc path: /Users/pecoraro/Build/Release/jsc
  error: /Users/pecoraro/Desktop/Xcode8.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/otool: for -S functionality, use llvm-nm with -print-armap

Notes:
- Dropping -S I see the same output but get a successful exit code. run-jsc-stress-tests still works.
Comment 1 Joseph Pecoraro 2017-04-05 16:35:04 PDT 
Created attachment 306335 [details]
[PATCH] Proposed Fix
Comment 2 Aakash Jain 2017-04-05 16:37:07 PDT 
Comment on attachment 306335 [details]
[PATCH] Proposed Fix

looks good to me.
Comment 3 WebKit Commit Bot 2017-04-05 17:13:55 PDT 
Comment on attachment 306335 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 306335

Committed r214981: <http://trac.webkit.org/changeset/214981>
Comment 4 WebKit Commit Bot 2017-04-05 17:13:56 PDT 
All reviewed patches have been landed.  Closing bug.