RESOLVED FIXED 170527
Remove run-jsc-stress-tests benign warning about otool '-S' switch
https://bugs.webkit.org/show_bug.cgi?id=170527
Summary Remove run-jsc-stress-tests benign warning about otool '-S' switch
Joseph Pecoraro
Reported 2017-04-05 16:34:02 PDT
Summary: Remove run-jsc-stress-tests benign warning about otool '-S' switch. The switch appears to not be necessary, since jscPath is a binary not a library: -S print the table of contents of a library Steps to reproduce: 1. $ run-jsc-stress-tests --release JSCTests/wasm.yaml => Output includes an error: Using the following jsc path: /Users/pecoraro/Build/Release/jsc error: /Users/pecoraro/Desktop/Xcode8.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/otool: for -S functionality, use llvm-nm with -print-armap Notes: - Dropping -S I see the same output but get a successful exit code. run-jsc-stress-tests still works.
Attachments
[PATCH] Proposed Fix (1.29 KB, patch)
2017-04-05 16:35 PDT, Joseph Pecoraro
no flags
Joseph Pecoraro
Comment 1 2017-04-05 16:35:04 PDT
Created attachment 306335 [details] [PATCH] Proposed Fix
Aakash Jain
Comment 2 2017-04-05 16:37:07 PDT
Comment on attachment 306335 [details] [PATCH] Proposed Fix looks good to me.
WebKit Commit Bot
Comment 3 2017-04-05 17:13:55 PDT
Comment on attachment 306335 [details] [PATCH] Proposed Fix Clearing flags on attachment: 306335 Committed r214981: <http://trac.webkit.org/changeset/214981>
WebKit Commit Bot
Comment 4 2017-04-05 17:13:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.