Bug 170521 - Refactor so WebsiteDataStores always have a StorageManager
Summary: Refactor so WebsiteDataStores always have a StorageManager
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on: 170578
Blocks:
  Show dependency tree / graph
 
Reported: 2017-04-05 14:16 PDT by Brady Eidson
Modified: 2017-04-07 09:03 PDT (History)
4 users (show)

See Also:

Attachments
Patch (8.64 KB, patch)
2017-04-05 14:22 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (8.67 KB, patch)
2017-04-05 14:27 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2017-04-05 14:16:54 PDT 
Refactor so WebsiteDataStores always have a StorageManager

Even for ephemeral sessions.
Comment 1 Brady Eidson 2017-04-05 14:22:02 PDT 
Created attachment 306314 [details]
Patch
Comment 2 Geoffrey Garen 2017-04-05 14:25:10 PDT 
Comment on attachment 306314 [details]
Patch

r=me
Comment 3 Brady Eidson 2017-04-05 14:27:57 PDT 
Created attachment 306316 [details]
Patch
Comment 4 WebKit Commit Bot 2017-04-05 15:38:27 PDT 
Comment on attachment 306316 [details]
Patch

Clearing flags on attachment: 306316

Committed r214973: <http://trac.webkit.org/changeset/214973>
Comment 5 WebKit Commit Bot 2017-04-05 15:38:29 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Commit Bot 2017-04-06 17:15:41 PDT 
Re-opened since this is blocked by bug 170578
Comment 7 Brady Eidson 2017-04-07 09:02:53 PDT 
There's significant UIProcess architecture issues that made this not be okay right now.

Basically, a single WebProcess connection can have multiple data stores associated with it, meaning multiple StorageManagers, and we can't have more than one StorageManager registered for message handling on a given connection.

I'll be resolving LocalStorage issues another way.